ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm - Issue 2829003002: Add CommandDispatcher to BrowserViewController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Issue 2829003002: Add CommandDispatcher to BrowserViewController. (Closed)

Patch Set: rohit comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

diff --git a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

index 645a9651e7c63e7355585bf13c83638e123f1d15..59bbe1723e55a3a0fd3cc7280c394dfaaa991e56 100644

--- a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

+++ b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

@@ -1249,7 +1249,7 @@ CGRect RectShiftedDownAndResizedForStatusBar(CGRect rect) {

// Evaluate the URL as JavaScript if its scheme is JavaScript.

NSString* jsToEval = [base::SysUTF8ToNSString(url.GetContent())

stringByRemovingPercentEncoding];

- [self.delegate loadJavaScriptFromLocationBar:jsToEval];

+ [self.urlLoader loadJavaScriptFromLocationBar:jsToEval];

} else {

// When opening a URL, force the omnibox to resign first responder. This

// will also close the popup.