Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

Issue 2828953002: [IndexedDB] Hold referenced to IDB::put blobs in the IDBRequest (Closed)
Patch Set: Name change, and added dcheck Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBRequest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
index bea4fbb3cd42c11d279decb0bb7cab603383e34f..1ddd3180fd4822f5ae6ebb4cba1a9eca170e02ab 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
@@ -241,6 +241,7 @@ bool IDBRequest::ShouldEnqueueEvent() const {
void IDBRequest::OnError(DOMException* error) {
IDB_TRACE("IDBRequest::onError()");
+ ClearPutOperationBlobs();
if (!ShouldEnqueueEvent())
return;
@@ -289,6 +290,7 @@ void IDBRequest::OnSuccess(std::unique_ptr<WebIDBCursor> backend,
void IDBRequest::OnSuccess(IDBKey* idb_key) {
IDB_TRACE("IDBRequest::onSuccess(IDBKey)");
+ ClearPutOperationBlobs();
if (!ShouldEnqueueEvent())
return;
@@ -360,6 +362,7 @@ void IDBRequest::OnSuccess() {
void IDBRequest::OnSuccessInternal(IDBAny* result) {
DCHECK(GetExecutionContext());
DCHECK(!pending_cursor_);
+ DCHECK(transit_blob_handles_.IsEmpty());
SetResult(result);
EnqueueEvent(Event::Create(EventTypeNames::success));
}
« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBRequest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698