Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

Issue 2828873003: Fixing display issue in bookmark manager. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <AppKit/AppKit.h> 5 #import <AppKit/AppKit.h>
6 6
7 #include "base/strings/string16.h" 7 #include "base/strings/string16.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/app/chrome_command_ids.h" 10 #include "chrome/app/chrome_command_ids.h"
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 NSString* title; 247 NSString* title;
248 NSMenuItem* item; 248 NSMenuItem* item;
249 NSMenu* menu = bridge_->menu_; 249 NSMenu* menu = bridge_->menu_;
250 250
251 BookmarkModel* model = bridge_->GetBookmarkModel(); 251 BookmarkModel* model = bridge_->GetBookmarkModel();
252 const BookmarkNode* root = model->bookmark_bar_node(); 252 const BookmarkNode* root = model->bookmark_bar_node();
253 EXPECT_TRUE(model && root); 253 EXPECT_TRUE(model && root);
254 EXPECT_EQ(0, [menu numberOfItems]); 254 EXPECT_EQ(0, [menu numberOfItems]);
255 255
256 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL, 256 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL,
257 IDS_BOOKMARK_BAR_OPEN_ALL, root, menu, true); 257 IDS_BOOKMARK_BAR_OPEN_ALL_COUNT, root, menu, true);
258 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW, 258 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW,
259 IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW, root, menu, true); 259 IDS_BOOKMARK_BAR_OPEN_ALL_COUNT_NEW_WINDOW, root, menu, true);
260 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO, 260 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO,
261 IDS_BOOKMARK_BAR_OPEN_INCOGNITO, root, menu, true); 261 IDS_BOOKMARK_BAR_OPEN_INCOGNITO, root, menu, true);
262 EXPECT_EQ(3, [menu numberOfItems]); 262 EXPECT_EQ(3, [menu numberOfItems]);
263 263
264 title = l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_ALL, 0); 264 title = l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_ALL_COUNT, 0);
265 item = [menu itemWithTitle:title]; 265 item = [menu itemWithTitle:title];
266 EXPECT_TRUE(item); 266 EXPECT_TRUE(item);
267 EXPECT_EQ(@selector(openAllBookmarks:), [item action]); 267 EXPECT_EQ(@selector(openAllBookmarks:), [item action]);
268 EXPECT_TRUE([item isEnabled]); 268 EXPECT_TRUE([item isEnabled]);
269 269
270 title = 270 title = l10n_util::GetPluralNSStringF(
271 l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW, 0); 271 IDS_BOOKMARK_BAR_OPEN_ALL_COUNT_NEW_WINDOW, 0);
272 item = [menu itemWithTitle:title]; 272 item = [menu itemWithTitle:title];
273 EXPECT_TRUE(item); 273 EXPECT_TRUE(item);
274 EXPECT_EQ(@selector(openAllBookmarksNewWindow:), [item action]); 274 EXPECT_EQ(@selector(openAllBookmarksNewWindow:), [item action]);
275 EXPECT_TRUE([item isEnabled]); 275 EXPECT_TRUE([item isEnabled]);
276 276
277 title = l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_INCOGNITO, 0); 277 title = l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_INCOGNITO, 0);
278 item = [menu itemWithTitle:title]; 278 item = [menu itemWithTitle:title];
279 EXPECT_TRUE(item); 279 EXPECT_TRUE(item);
280 EXPECT_EQ(@selector(openAllBookmarksIncognitoWindow:), [item action]); 280 EXPECT_EQ(@selector(openAllBookmarksIncognitoWindow:), [item action]);
281 EXPECT_TRUE([item isEnabled]); 281 EXPECT_TRUE([item isEnabled]);
282 282
283 ClearBookmarkMenu(bridge_.get(), menu); 283 ClearBookmarkMenu(bridge_.get(), menu);
284 EXPECT_EQ(0, [menu numberOfItems]); 284 EXPECT_EQ(0, [menu numberOfItems]);
285 285
286 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL, 286 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL,
287 IDS_BOOKMARK_BAR_OPEN_ALL, root, menu, false); 287 IDS_BOOKMARK_BAR_OPEN_ALL_COUNT, root, menu, false);
288 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW, 288 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW,
289 IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW, root, menu, false); 289 IDS_BOOKMARK_BAR_OPEN_ALL_COUNT_NEW_WINDOW, root, menu, false);
290 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO, 290 AddItemToMenu(bridge_.get(), IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO,
291 IDS_BOOKMARK_BAR_OPEN_INCOGNITO, root, menu, false); 291 IDS_BOOKMARK_BAR_OPEN_INCOGNITO, root, menu, false);
292 EXPECT_EQ(3, [menu numberOfItems]); 292 EXPECT_EQ(3, [menu numberOfItems]);
293 293
294 title = l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_ALL, 0); 294 title = l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_ALL_COUNT, 0);
295 item = [menu itemWithTitle:title]; 295 item = [menu itemWithTitle:title];
296 EXPECT_TRUE(item); 296 EXPECT_TRUE(item);
297 EXPECT_EQ(nil, [item action]); 297 EXPECT_EQ(nil, [item action]);
298 EXPECT_FALSE([item isEnabled]); 298 EXPECT_FALSE([item isEnabled]);
299 299
300 title = 300 title = l10n_util::GetPluralNSStringF(
301 l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW, 0); 301 IDS_BOOKMARK_BAR_OPEN_ALL_COUNT_NEW_WINDOW, 0);
302 item = [menu itemWithTitle:title]; 302 item = [menu itemWithTitle:title];
303 EXPECT_TRUE(item); 303 EXPECT_TRUE(item);
304 EXPECT_EQ(nil, [item action]); 304 EXPECT_EQ(nil, [item action]);
305 EXPECT_FALSE([item isEnabled]); 305 EXPECT_FALSE([item isEnabled]);
306 306
307 title = l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_INCOGNITO, 0); 307 title = l10n_util::GetPluralNSStringF(IDS_BOOKMARK_BAR_OPEN_INCOGNITO, 0);
308 item = [menu itemWithTitle:title]; 308 item = [menu itemWithTitle:title];
309 EXPECT_TRUE(item); 309 EXPECT_TRUE(item);
310 EXPECT_EQ(nil, [item action]); 310 EXPECT_EQ(nil, [item action]);
311 EXPECT_FALSE([item isEnabled]); 311 EXPECT_FALSE([item isEnabled]);
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 EXPECT_TRUE([item image]); 395 EXPECT_TRUE([item image]);
396 396
397 model->SetTitle(node, ASCIIToUTF16("New Title")); 397 model->SetTitle(node, ASCIIToUTF16("New Title"));
398 398
399 item = [menu itemWithTitle:@"Test Item"]; 399 item = [menu itemWithTitle:@"Test Item"];
400 EXPECT_FALSE(item); 400 EXPECT_FALSE(item);
401 item = [menu itemWithTitle:@"New Title"]; 401 item = [menu itemWithTitle:@"New Title"];
402 EXPECT_TRUE(item); 402 EXPECT_TRUE(item);
403 } 403 }
404 404
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698