Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2828873002: Revert "Remove JavaScriptBackend from ClosedWorldBase" (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/js_backend/interceptor_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index dae68b71c201b4c8264ab4e9fb8c96e99dc5d009..f655159c43beac958c8ff086f63f0d8aea86b5a6 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -757,7 +757,6 @@ class JavaScriptBackend {
});
}
- /// Called before processing of the resolution queue is started.
void onResolutionStart(ResolutionEnqueuer enqueuer) {
// TODO(johnniwinther): Avoid the compiler.elementEnvironment.getThisType
// calls. Currently needed to ensure resolution of the classes for various
@@ -772,14 +771,7 @@ class JavaScriptBackend {
validateInterceptorImplementsAllObjectMethods(commonElements.jsNullClass);
}
- /// Called when the resolution queue has been closed.
- void onResolutionEnd() {
- _backendUsage = backendUsageBuilder.close();
- _interceptorData = interceptorDataBuilder.onResolutionComplete();
- }
-
- /// Called when the closed world from resolution has been computed.
- void onResolutionClosedWorld(
+ void onResolutionComplete(
ClosedWorld closedWorld, ClosedWorldRefiner closedWorldRefiner) {
for (MemberEntity entity
in compiler.enqueuer.resolution.processedEntities) {
@@ -787,6 +779,7 @@ class JavaScriptBackend {
}
mirrorsDataBuilder.computeMembersNeededForReflection(
compiler.enqueuer.resolution.worldBuilder, closedWorld);
+ _backendUsage = backendUsageBuilder.close();
_rtiNeed = rtiNeedBuilder.computeRuntimeTypesNeed(
compiler.enqueuer.resolution.worldBuilder,
closedWorld,
@@ -794,6 +787,7 @@ class JavaScriptBackend {
commonElements,
_backendUsage,
enableTypeAssertions: compiler.options.enableTypeAssertions);
+ _interceptorData = interceptorDataBuilder.onResolutionComplete(closedWorld);
_oneShotInterceptorData =
new OneShotInterceptorData(interceptorData, commonElements);
mirrorsResolutionAnalysis.onResolutionComplete();
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/js_backend/interceptor_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698