Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2828873002: Revert "Remove JavaScriptBackend from ClosedWorldBase" (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -357 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 4 chunks +3 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/interceptor_data.dart View 11 chunks +19 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 4 chunks +9 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 1 chunk +2 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 15 chunks +130 lines, -264 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 3 chunks +10 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
Committed patchset #1 (id:1) manually as 6c75646b3e3dded2622a0098210d1700af35461c (presubmit successful).
3 years, 8 months ago (2017-04-19 19:55:27 UTC) #2
Johnni Winther
3 years, 8 months ago (2017-04-20 11:26:00 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698