Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2828863002: [DevTools] enable async stacks by default (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
index fb5ad2e18ee5a65cb7081b2287c74b76068b3b73..49effbfa759f5f3e14cf17fd5b809aefef0196a1 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -62,7 +62,7 @@ SDK.DebuggerModel = class extends SDK.SDKModel {
this._isPausing = false;
Common.moduleSetting('pauseOnExceptionEnabled').addChangeListener(this._pauseOnExceptionStateChanged, this);
Common.moduleSetting('pauseOnCaughtException').addChangeListener(this._pauseOnExceptionStateChanged, this);
- Common.moduleSetting('enableAsyncStackTraces').addChangeListener(this.asyncStackTracesStateChanged, this);
+ Common.moduleSetting('disableAsyncStackTraces').addChangeListener(this.asyncStackTracesStateChanged, this);
/** @type {!Map<string, string>} */
this._fileURLToNodeJSPath = new Map();
@@ -177,8 +177,8 @@ SDK.DebuggerModel = class extends SDK.SDKModel {
}
asyncStackTracesStateChanged() {
dgozman 2017/04/21 23:39:17 While we are here, let's make this private.
kozy 2017/04/22 00:02:57 Done.
- const maxAsyncStackChainDepth = 8;
- var enabled = Common.moduleSetting('enableAsyncStackTraces').get() && this._debuggerEnabled;
+ const maxAsyncStackChainDepth = 32;
+ var enabled = !Common.moduleSetting('disableAsyncStackTraces').get() && this._debuggerEnabled;
this._agent.setAsyncCallStackDepth(enabled ? maxAsyncStackChainDepth : 0);
}
@@ -864,7 +864,7 @@ SDK.DebuggerModel = class extends SDK.SDKModel {
this._sourceMapManager.dispose();
Common.moduleSetting('pauseOnExceptionEnabled').removeChangeListener(this._pauseOnExceptionStateChanged, this);
Common.moduleSetting('pauseOnCaughtException').removeChangeListener(this._pauseOnExceptionStateChanged, this);
- Common.moduleSetting('enableAsyncStackTraces').removeChangeListener(this.asyncStackTracesStateChanged, this);
+ Common.moduleSetting('disableAsyncStackTraces').removeChangeListener(this.asyncStackTracesStateChanged, this);
}
/**

Powered by Google App Engine
This is Rietveld 408576698