chrome/browser/resources/chromeos/login/oobe_screen_reset.html - Issue 282883004: Added accessible title, icon-title and notification for factory reset screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_reset.html

Issue 282883004: Added accessible title, icon-title and notification for factory reset screen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/login/oobe_screen_reset.html

diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_reset.html b/chrome/browser/resources/chromeos/login/oobe_screen_reset.html

index 6e311d25bed0b0ef70ade32d61c5cc2c6162396e..a9ced78cca65b7a5d357e10ad22fb532df9dd53e 100644

--- a/chrome/browser/resources/chromeos/login/oobe_screen_reset.html

+++ b/chrome/browser/resources/chromeos/login/oobe_screen_reset.html

@@ -1,7 +1,9 @@

-<div class="step faded hidden no-logo" id="reset" hidden>

+<div class="step faded hidden no-logo" id="reset" role="group" hidden

+ i18n-values="aria-label:resetScreenAccessibleTitle">

- <img id="reset-warning-icon" src="chrome://theme/IDR_RESET_WARNING" alt="">

+ <img id="reset-warning-icon" src="chrome://theme/IDR_RESET_WARNING"

+ i18n-values="title:resetScreenIconTitle">

dzhioev (left Google) 2014/05/15 10:54:04 I think the "alt" attribute is more preferable for

merkulova 2014/05/22 11:17:32 Done.

<div id="reset-warning-data-details" class="reset-text"

« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/chromeos/login/oobe_screen_reset.js » ('j') | no next file with comments »