Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 282883004: Added accessible title, icon-title and notification for factory reset screen. (Closed)

Created:
6 years, 7 months ago by merkulova
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Added accessible title, icon-title and notification for factory reset screen. BUG=373257 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272231

Patch Set 1 #

Total comments: 2

Patch Set 2 : Title->alt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_reset.html View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_reset.js View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
merkulova
6 years, 7 months ago (2014-05-14 11:30:50 UTC) #1
dzhioev (left Google)
https://codereview.chromium.org/282883004/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_reset.html File chrome/browser/resources/chromeos/login/oobe_screen_reset.html (right): https://codereview.chromium.org/282883004/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_reset.html#newcode6 chrome/browser/resources/chromeos/login/oobe_screen_reset.html:6: i18n-values="title:resetScreenIconTitle"> I think the "alt" attribute is more preferable ...
6 years, 7 months ago (2014-05-15 10:54:04 UTC) #2
merkulova
https://codereview.chromium.org/282883004/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_reset.html File chrome/browser/resources/chromeos/login/oobe_screen_reset.html (right): https://codereview.chromium.org/282883004/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_reset.html#newcode6 chrome/browser/resources/chromeos/login/oobe_screen_reset.html:6: i18n-values="title:resetScreenIconTitle"> On 2014/05/15 10:54:04, dzhioev wrote: > I think ...
6 years, 7 months ago (2014-05-22 11:17:31 UTC) #3
dzhioev (left Google)
On 2014/05/22 11:17:31, merkulova wrote: > https://codereview.chromium.org/282883004/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_reset.html > File chrome/browser/resources/chromeos/login/oobe_screen_reset.html (right): > > https://codereview.chromium.org/282883004/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_reset.html#newcode6 > ...
6 years, 7 months ago (2014-05-22 11:57:09 UTC) #4
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 7 months ago (2014-05-22 12:02:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/282883004/20001
6 years, 7 months ago (2014-05-22 12:04:30 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 18:05:56 UTC) #7
Message was sent while issue was closed. 
Change committed as 272231

Powered by Google App Engine
This is Rietveld 408576698