GN: Tighten up test target visibility + refactorings

webrtc/modules/desktop_capture/BUILD.gn

Index: webrtc/modules/desktop_capture/BUILD.gn
diff --git a/webrtc/modules/desktop_capture/BUILD.gn b/webrtc/modules/desktop_capture/BUILD.gn
index 35ca3a447f3550ef735af9de5a442d4961255472..5854b3438af8631aa5b443a1453ad6e14c0fd8c3 100644
--- a/webrtc/modules/desktop_capture/BUILD.gn
+++ b/webrtc/modules/desktop_capture/BUILD.gn
@@ -35,6 +35,13 @@ rtc_static_library("primitives") {
 if (rtc_include_tests) {
   rtc_source_set("desktop_capture_modules_tests") {
     testonly = true
+
+    # Skip restricting visibility on mobile platforms since the tests on those
+    # gets additional generated targets which would require many lines here to
+    # cover (which would be confusing to read and hard to maintain).
+    if (!is_android && !is_ios) {
+      visibility = [ "//webrtc/modules:modules_tests" ]
+    }
     sources = []
     deps = []
     if (rtc_desktop_capture_supported) {
@@ -57,6 +64,13 @@ if (rtc_include_tests) {
 
   rtc_source_set("desktop_capture_unittests") {
     testonly = true
+
+    # Skip restricting visibility on mobile platforms since the tests on those
+    # gets additional generated targets which would require many lines here to
+    # cover (which would be confusing to read and hard to maintain).
+    if (!is_android && !is_ios) {
+      visibility = [ "//webrtc/modules:modules_unittests" ]
+    }
     sources = [
       "blank_detector_desktop_capturer_wrapper_unittest.cc",
       "desktop_and_cursor_composer_unittest.cc",