Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: webrtc/modules/rtp_rtcp/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Move out fec_test_helper from rtc_include_tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/BUILD.gn ('k') | webrtc/modules/utility/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../webrtc.gni") 9 import("../../webrtc.gni")
10 10
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 185 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
186 186
187 if (is_win) { 187 if (is_win) {
188 cflags = [ 188 cflags = [
189 # TODO(kjellander): Bug 261: fix this warning. 189 # TODO(kjellander): Bug 261: fix this warning.
190 "/wd4373", # virtual function override. 190 "/wd4373", # virtual function override.
191 ] 191 ]
192 } 192 }
193 } 193 }
194 194
195 rtc_source_set("fec_test_helper") {
196 testonly = true
197 sources = [
198 "source/fec_test_helper.cc",
199 "source/fec_test_helper.h",
200 ]
201 deps = [
202 ":rtp_rtcp",
203 "../../base:rtc_base_approved",
204 ]
205
206 # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
207 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
208 if (!build_with_chromium && is_clang) {
209 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
210 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
211 }
212 }
213
195 if (rtc_include_tests) { 214 if (rtc_include_tests) {
196 rtc_executable("test_packet_masks_metrics") { 215 rtc_executable("test_packet_masks_metrics") {
197 testonly = true 216 testonly = true
198 217
199 sources = [ 218 sources = [
200 "test/testFec/average_residual_loss_xor_codes.h", 219 "test/testFec/average_residual_loss_xor_codes.h",
201 "test/testFec/test_packet_masks_metrics.cc", 220 "test/testFec/test_packet_masks_metrics.cc",
202 ] 221 ]
203 222
204 deps = [ 223 deps = [
205 ":rtp_rtcp", 224 ":rtp_rtcp",
206 "//testing/gtest", 225 "//testing/gtest",
207 "//webrtc/test:test_main", 226 "//webrtc/test:test_main",
208 ] 227 ]
209 } # test_packet_masks_metrics 228 } # test_packet_masks_metrics
210 229
211 rtc_source_set("rtp_rtcp_modules_tests") { 230 rtc_source_set("rtp_rtcp_modules_tests") {
212 testonly = true 231 testonly = true
232
233 # Skip restricting visibility on mobile platforms since the tests on those
234 # gets additional generated targets which would require many lines here to
235 # cover (which would be confusing to read and hard to maintain).
236 if (!is_android && !is_ios) {
237 visibility = [ "//webrtc/modules:modules_tests" ]
238 }
213 sources = [ 239 sources = [
214 "test/testFec/test_fec.cc", 240 "test/testFec/test_fec.cc",
215 ] 241 ]
216 deps = [ 242 deps = [
217 ":rtp_rtcp", 243 ":rtp_rtcp",
218 "../../base:rtc_base_approved", 244 "../../base:rtc_base_approved",
219 "../../test:test_support", 245 "../../test:test_support",
220 ] 246 ]
221 if (!build_with_chromium && is_clang) { 247 if (!build_with_chromium && is_clang) {
222 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 248 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
223 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 249 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
224 } 250 }
225 } 251 }
226 252
253 rtc_source_set("mock_rtp_rtcp") {
254 testonly = true
255 sources = [
256 "mocks/mock_rtp_rtcp.h",
257 ]
258 deps = [
259 ":rtp_rtcp",
260 "../../base:rtc_base_approved",
261 "../../test:test_support",
262 ]
263 }
264
227 rtc_source_set("rtp_rtcp_unittests") { 265 rtc_source_set("rtp_rtcp_unittests") {
228 testonly = true 266 testonly = true
267
268 # Skip restricting visibility on mobile platforms since the tests on those
269 # gets additional generated targets which would require many lines here to
270 # cover (which would be confusing to read and hard to maintain).
271 if (!is_android && !is_ios) {
272 visibility = [ "//webrtc/modules:modules_unittests" ]
273 }
229 sources = [ 274 sources = [
230 "mocks/mock_rtp_rtcp.h",
231 "source/byte_io_unittest.cc", 275 "source/byte_io_unittest.cc",
232 "source/fec_test_helper.cc",
233 "source/fec_test_helper.h",
234 "source/flexfec_header_reader_writer_unittest.cc", 276 "source/flexfec_header_reader_writer_unittest.cc",
235 "source/flexfec_receiver_unittest.cc", 277 "source/flexfec_receiver_unittest.cc",
236 "source/flexfec_sender_unittest.cc", 278 "source/flexfec_sender_unittest.cc",
237 "source/nack_rtx_unittest.cc", 279 "source/nack_rtx_unittest.cc",
238 "source/packet_loss_stats_unittest.cc", 280 "source/packet_loss_stats_unittest.cc",
239 "source/playout_delay_oracle_unittest.cc", 281 "source/playout_delay_oracle_unittest.cc",
240 "source/receive_statistics_unittest.cc", 282 "source/receive_statistics_unittest.cc",
241 "source/remote_ntp_time_estimator_unittest.cc", 283 "source/remote_ntp_time_estimator_unittest.cc",
242 "source/rtcp_nack_stats_unittest.cc", 284 "source/rtcp_nack_stats_unittest.cc",
243 "source/rtcp_packet/app_unittest.cc", 285 "source/rtcp_packet/app_unittest.cc",
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 "source/ulpfec_header_reader_writer_unittest.cc", 326 "source/ulpfec_header_reader_writer_unittest.cc",
285 "source/ulpfec_receiver_unittest.cc", 327 "source/ulpfec_receiver_unittest.cc",
286 "source/vp8_partition_aggregator_unittest.cc", 328 "source/vp8_partition_aggregator_unittest.cc",
287 "test/testAPI/test_api.cc", 329 "test/testAPI/test_api.cc",
288 "test/testAPI/test_api.h", 330 "test/testAPI/test_api.h",
289 "test/testAPI/test_api_audio.cc", 331 "test/testAPI/test_api_audio.cc",
290 "test/testAPI/test_api_rtcp.cc", 332 "test/testAPI/test_api_rtcp.cc",
291 "test/testAPI/test_api_video.cc", 333 "test/testAPI/test_api_video.cc",
292 ] 334 ]
293 deps = [ 335 deps = [
336 ":fec_test_helper",
337 ":mock_rtp_rtcp",
294 ":rtp_rtcp", 338 ":rtp_rtcp",
295 "../..:webrtc_common", 339 "../..:webrtc_common",
296 "../../api:transport_api", 340 "../../api:transport_api",
297 "../../base:rtc_base_approved", 341 "../../base:rtc_base_approved",
298 "../../common_video:common_video", 342 "../../common_video:common_video",
299 "../../system_wrappers:system_wrappers", 343 "../../system_wrappers:system_wrappers",
300 "../../test:field_trial", 344 "../../test:field_trial",
301 "../../test:rtp_test_utils", 345 "../../test:rtp_test_utils",
302 "../../test:test_common", 346 "../../test:test_common",
303 "../../test:test_support", 347 "../../test:test_support",
304 "//testing/gmock", 348 "//testing/gmock",
305 ] 349 ]
306 350
307 # TODO(jschuh): bugs.webrtc.org/1348: fix this warning. 351 # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
308 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 352 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
309 if (!build_with_chromium && is_clang) { 353 if (!build_with_chromium && is_clang) {
310 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 354 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
311 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 355 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
312 } 356 }
313 } 357 }
314 } 358 }
OLDNEW
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/BUILD.gn ('k') | webrtc/modules/utility/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698