GN: Tighten up test target visibility + refactorings

webrtc/modules/rtp_rtcp/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../webrtc.gni")
 
@@ skipping 174 matching lines @@
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   if (is_win) {
     cflags = [
       # TODO(kjellander): Bug 261: fix this warning.
       "/wd4373",  # virtual function override.
     ]
   }
 }
 
+rtc_source_set("fec_test_helper") {
+  testonly = true
+  sources = [
+    "source/fec_test_helper.cc",
+    "source/fec_test_helper.h",
+  ]
+  deps = [
+    ":rtp_rtcp",
+    "../../base:rtc_base_approved",
+  ]
+
+  # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
+  configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+  }
+}
+
 if (rtc_include_tests) {
   rtc_executable("test_packet_masks_metrics") {
     testonly = true
 
     sources = [
       "test/testFec/average_residual_loss_xor_codes.h",
       "test/testFec/test_packet_masks_metrics.cc",
     ]
 
     deps = [
       ":rtp_rtcp",
       "//testing/gtest",
       "//webrtc/test:test_main",
     ]
   }  # test_packet_masks_metrics
 
   rtc_source_set("rtp_rtcp_modules_tests") {
     testonly = true
+
+    # Skip restricting visibility on mobile platforms since the tests on those
+    # gets additional generated targets which would require many lines here to
+    # cover (which would be confusing to read and hard to maintain).
+    if (!is_android && !is_ios) {
+      visibility = [ "//webrtc/modules:modules_tests" ]
+    }
     sources = [
       "test/testFec/test_fec.cc",
     ]
     deps = [
       ":rtp_rtcp",
       "../../base:rtc_base_approved",
       "../../test:test_support",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
+  rtc_source_set("mock_rtp_rtcp") {
+    testonly = true
+    sources = [
+      "mocks/mock_rtp_rtcp.h",
+    ]
+    deps = [
+      ":rtp_rtcp",
+      "../../base:rtc_base_approved",
+      "../../test:test_support",
+    ]
+  }
+
   rtc_source_set("rtp_rtcp_unittests") {
     testonly = true
+
+    # Skip restricting visibility on mobile platforms since the tests on those
+    # gets additional generated targets which would require many lines here to
+    # cover (which would be confusing to read and hard to maintain).
+    if (!is_android && !is_ios) {
+      visibility = [ "//webrtc/modules:modules_unittests" ]
+    }
     sources = [
-      "mocks/mock_rtp_rtcp.h",
       "source/byte_io_unittest.cc",
-      "source/fec_test_helper.cc",
-      "source/fec_test_helper.h",
       "source/flexfec_header_reader_writer_unittest.cc",
       "source/flexfec_receiver_unittest.cc",
       "source/flexfec_sender_unittest.cc",
       "source/nack_rtx_unittest.cc",
       "source/packet_loss_stats_unittest.cc",
       "source/playout_delay_oracle_unittest.cc",
       "source/receive_statistics_unittest.cc",
       "source/remote_ntp_time_estimator_unittest.cc",
       "source/rtcp_nack_stats_unittest.cc",
       "source/rtcp_packet/app_unittest.cc",
@@ skipping 40 matching lines @@
       "source/ulpfec_header_reader_writer_unittest.cc",
       "source/ulpfec_receiver_unittest.cc",
       "source/vp8_partition_aggregator_unittest.cc",
       "test/testAPI/test_api.cc",
       "test/testAPI/test_api.h",
       "test/testAPI/test_api_audio.cc",
       "test/testAPI/test_api_rtcp.cc",
       "test/testAPI/test_api_video.cc",
     ]
     deps = [
+      ":fec_test_helper",
+      ":mock_rtp_rtcp",
       ":rtp_rtcp",
       "../..:webrtc_common",
       "../../api:transport_api",
       "../../base:rtc_base_approved",
       "../../common_video:common_video",
       "../../system_wrappers:system_wrappers",
       "../../test:field_trial",
       "../../test:rtp_test_utils",
       "../../test:test_common",
       "../../test:test_support",
       "//testing/gmock",
     ]
 
     # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
     configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }