Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/BindingManager.java

Issue 2828793002: Refactoring ChildProcessConnection. (Closed)
Patch Set: More test fixing. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/BindingManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/BindingManager.java b/content/public/android/java/src/org/chromium/content/browser/BindingManager.java
index 75fda5a81ead4a53636c4c41949ac40422913879..dfa358139c6a3e5d975c3a164d62b57ead1dd9be 100644
--- a/content/public/android/java/src/org/chromium/content/browser/BindingManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/BindingManager.java
@@ -32,7 +32,7 @@ public interface BindingManager {
* Registers a freshly started child process. This can be called on any thread.
* @param pid handle of the service process
*/
- void addNewConnection(int pid, ChildProcessConnection connection);
+ void addNewConnection(int pid, ManagedChildProcessConnection connection);
/**
* Called when the service visibility changes or is determined for the first time. On low-memory
@@ -70,18 +70,11 @@ public interface BindingManager {
void onBroughtToForeground();
/**
- * @return True iff the given service process is protected from the out-of-memory killing, or it
- * was protected when it died unexpectedly. This can be used to decide if a disconnection of a
- * renderer was a crash or a probable out-of-memory kill. This can be called on any thread.
- */
- boolean isOomProtected(int pid);
-
- /**
* Should be called when the connection to the child process goes away (either after a clean
* exit or an unexpected crash). At this point we let go of the reference to the
* ChildProcessConnection. This can be called on any thread.
*/
- void clearConnection(int pid);
+ void removeConnection(int pid);
/**
* Starts moderate binding management.

Powered by Google App Engine
This is Rietveld 408576698