Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

Issue 2828793002: Refactoring ChildProcessConnection. (Closed)
Patch Set: More test fixing. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/lint/suppressions.xml ('k') | content/public/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
index efa5df228b06065f875032590699b7556ed73429..0441146430abc8f4571157a4316336b3581a583a 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
@@ -26,8 +26,8 @@ import org.chromium.chrome.test.util.ChromeRestriction;
import org.chromium.chrome.test.util.ChromeTabUtils;
import org.chromium.chrome.test.util.PrerenderTestHelper;
import org.chromium.content.browser.BindingManager;
-import org.chromium.content.browser.ChildProcessConnection;
import org.chromium.content.browser.ChildProcessLauncher;
+import org.chromium.content.browser.ManagedChildProcessConnection;
import org.chromium.content.browser.test.ChildProcessAllocatorSettings;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
@@ -99,7 +99,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch
}
@Override
- public void addNewConnection(int pid, ChildProcessConnection connection) {
+ public void addNewConnection(int pid, ManagedChildProcessConnection connection) {
synchronized (mVisibilityCallsMap) {
mVisibilityCallsMap.put(pid, "");
}
@@ -132,12 +132,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch
public void onBroughtToForeground() {}
@Override
- public boolean isOomProtected(int pid) {
- return false;
- }
-
- @Override
- public void clearConnection(int pid) {}
+ public void removeConnection(int pid) {}
@Override
public void startModerateBindingManagement(Context context, int maxSize) {}
« no previous file with comments | « build/android/lint/suppressions.xml ('k') | content/public/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698