ios/chrome/browser/ui/util/label_link_controller.h - Issue 2828743002: LabelObserver is no longer retained by the label

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/util/label_link_controller.h

Issue 2828743002: LabelObserver is no longer retained by the label (Closed)

Patch Set: Address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/util/label_link_controller.h

diff --git a/ios/chrome/browser/ui/util/label_link_controller.h b/ios/chrome/browser/ui/util/label_link_controller.h

index 35e8928017d3f85eb8cc843f42d1673c8711764a..2fab7535283c01bbdad3efd6b7834faa279b7912 100644

--- a/ios/chrome/browser/ui/util/label_link_controller.h

+++ b/ios/chrome/browser/ui/util/label_link_controller.h

@@ -45,8 +45,8 @@ class GURL;

// attributed text accordingly.

@property(nonatomic, retain) UIFont* linkFont;

-// Creates a new controller for |label|, whose lifetime is expected to exceed

-// that of the receiver. |action| is the block called for any tapped link.

+// Creates a new controller for |label|, keeping a strong reference. |action| is

+// the block called for any tapped link.

- (instancetype)initWithLabel:(UILabel*)label

action:(ProceduralBlockWithURL)action;