chromeos/network/onc/onc_validator_unittest.cc - Issue 2828713002: Enable client certificate patterns in device ONC policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_validator_unittest.cc

Issue 2828713002: Enable client certificate patterns in device ONC policy (Closed)

Patch Set: Addressed comments - more DCHECKs, use PostTask..WithReply in client_cert_resolver.cc. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_validator_unittest.cc

diff --git a/chromeos/network/onc/onc_validator_unittest.cc b/chromeos/network/onc/onc_validator_unittest.cc

index 92b3c879e7de449d62010603efa5991a5430729a..4102a0ccb3f3f14dc941dec08adfd9e3c554447d 100644

--- a/chromeos/network/onc/onc_validator_unittest.cc

+++ b/chromeos/network/onc/onc_validator_unittest.cc

@@ -544,11 +544,6 @@ INSTANTIATE_TEST_CASE_P(

&kNetworkConfigurationSignature,

true),

ExpectBothNotValid("", "")),

- std::make_pair(OncParams("network-with-client-cert-pattern",

- &kNetworkConfigurationSignature,

- true,

- ::onc::ONC_SOURCE_DEVICE_POLICY),

- ExpectBothNotValid("", "")),

std::make_pair(OncParams("openvpn-invalid-verify-x509-type",

&kNetworkConfigurationSignature,

false),