third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h - Issue 2828643002: Make customElements.define faster

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

Issue 2828643002: Make customElements.define faster

Patch Set: Try to make Android builder happy. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h b/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

index f710de0b9183ce631156b6a27e521ad933b79aee..a1c2b223a291c8b110b64f4dbd35e12184d88b13 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

@@ -35,7 +35,8 @@ class TestCustomElementDefinitionBuilder

bool CheckConstructorNotRegistered() override { return true; }

bool CheckPrototype() override { return true; }

bool RememberOriginalProperties() override { return true; }

- CustomElementDefinition* Build(const CustomElementDescriptor&) override;

+ CustomElementDefinition* Build(const CustomElementDescriptor&,

+ CustomElementDefinition::Id) override;

};

class TestCustomElementDefinition : public CustomElementDefinition {