Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

Issue 2828643002: Make customElements.define faster
Patch Set: Remove some unneeded casts. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
index 5ba1190e4d2f4a60393f76978816fc84d20681f7..752dfe524782499d3362cb987ad69bbdbbb9163d 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
@@ -35,18 +35,18 @@ class CORE_EXPORT ScriptCustomElementDefinitionBuilder
CustomElementRegistry*,
const ScriptValue& constructor_script_value,
ExceptionState&);
- ~ScriptCustomElementDefinitionBuilder();
+ ~ScriptCustomElementDefinitionBuilder() {}
bool CheckConstructorIntrinsics() override;
bool CheckConstructorNotRegistered() override;
bool CheckPrototype() override;
bool RememberOriginalProperties() override;
- CustomElementDefinition* Build(const CustomElementDescriptor&) override;
+ CustomElementDefinition* Build(const CustomElementDescriptor&,
+ CustomElementDefinition::Id) override;
private:
static ScriptCustomElementDefinitionBuilder* stack_;
- ScriptCustomElementDefinitionBuilder* prev_;
RefPtr<ScriptState> script_state_;
Member<CustomElementRegistry> registry_;
v8::Local<v8::Value> constructor_value_;
@@ -59,11 +59,20 @@ class CORE_EXPORT ScriptCustomElementDefinitionBuilder
HashSet<AtomicString> observed_attributes_;
ExceptionState& exception_state_;
- bool ValueForName(const v8::Local<v8::Object>&,
+ bool ValueForName(v8::Isolate*,
+ v8::Local<v8::Context>&,
+ const v8::TryCatch&,
+ const v8::Local<v8::Object>&,
const StringView&,
v8::Local<v8::Value>&) const;
- bool CallableForName(const StringView&, v8::Local<v8::Function>&) const;
- bool RetrieveObservedAttributes();
+ bool CallableForName(v8::Isolate*,
+ v8::Local<v8::Context>&,
+ const v8::TryCatch&,
+ const StringView&,
+ v8::Local<v8::Function>&) const;
+ bool RetrieveObservedAttributes(v8::Isolate*,
+ v8::Local<v8::Context>&,
+ const v8::TryCatch&);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698