Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Issue 2828643002: Make customElements.define faster
Patch Set: Remove some unneeded casts. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
index abed38bdb862d1b9c25793729af52e0394b3506b..9326cbd4cb7088d70e3aa186b8b6280ac423cfb5 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
@@ -5,8 +5,8 @@
#ifndef ScriptCustomElementDefinition_h
#define ScriptCustomElementDefinition_h
-#include "bindings/core/v8/ScopedPersistent.h"
#include "bindings/core/v8/ScriptState.h"
+#include "bindings/core/v8/TraceWrapperV8Reference.h"
#include "core/CoreExport.h"
#include "core/dom/custom/CustomElementDefinition.h"
#include "platform/wtf/Noncopyable.h"
@@ -32,15 +32,18 @@ class CORE_EXPORT ScriptCustomElementDefinition final
ScriptState*,
CustomElementRegistry*,
const CustomElementDescriptor&,
+ CustomElementDefinition::Id,
const v8::Local<v8::Object>& constructor,
const v8::Local<v8::Function>& connected_callback,
const v8::Local<v8::Function>& disconnected_callback,
const v8::Local<v8::Function>& adopted_callback,
const v8::Local<v8::Function>& attribute_changed_callback,
- const HashSet<AtomicString>& observed_attributes);
+ HashSet<AtomicString>&& observed_attributes);
virtual ~ScriptCustomElementDefinition() = default;
+ DECLARE_VIRTUAL_TRACE_WRAPPERS();
+
v8::Local<v8::Object> Constructor() const;
HTMLElement* CreateElementSync(Document&, const QualifiedName&) override;
@@ -68,7 +71,7 @@ class CORE_EXPORT ScriptCustomElementDefinition final
const v8::Local<v8::Function>& disconnected_callback,
const v8::Local<v8::Function>& adopted_callback,
const v8::Local<v8::Function>& attribute_changed_callback,
- const HashSet<AtomicString>& observed_attributes);
+ HashSet<AtomicString>&& observed_attributes);
// Implementations of |CustomElementDefinition|
ScriptValue GetConstructorForScript() final;
@@ -88,11 +91,11 @@ class CORE_EXPORT ScriptCustomElementDefinition final
ExceptionState&);
RefPtr<ScriptState> script_state_;
- ScopedPersistent<v8::Object> constructor_;
- ScopedPersistent<v8::Function> connected_callback_;
- ScopedPersistent<v8::Function> disconnected_callback_;
- ScopedPersistent<v8::Function> adopted_callback_;
- ScopedPersistent<v8::Function> attribute_changed_callback_;
+ TraceWrapperV8Reference<v8::Object> constructor_;
+ TraceWrapperV8Reference<v8::Function> connected_callback_;
+ TraceWrapperV8Reference<v8::Function> disconnected_callback_;
+ TraceWrapperV8Reference<v8::Function> adopted_callback_;
+ TraceWrapperV8Reference<v8::Function> attribute_changed_callback_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698