Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2828573002: Fix for instance fields inference when a setter has no parameter. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for instance fields inference when a setter has no parameter. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/955d7cf037d882a539e9d7551b34ee836c5f4382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/top_level_inference_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-18 18:35:24 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-18 18:59:08 UTC) #2
scheglov
3 years, 8 months ago (2017-04-18 19:26:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
955d7cf037d882a539e9d7551b34ee836c5f4382 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698