RTCCertificate.getFingerprints added (exposed to the web)

third_party/WebKit/Source/modules/peerconnection/RTCCertificate.cpp

 /*
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "modules/peerconnection/RTCCertificate.h"
 
+#include "bindings/core/v8/ScriptState.h"
+#include "bindings/core/v8/ToV8.h"
+#include "bindings/core/v8/V8Binding.h"
 #include "platform/wtf/PtrUtil.h"
 
 namespace blink {
 
 RTCCertificate::RTCCertificate(std::unique_ptr<WebRTCCertificate> certificate)
     : certificate_(WTF::WrapUnique(certificate.release())) {}
 
 std::unique_ptr<WebRTCCertificate> RTCCertificate::CertificateShallowCopy()
     const {
   return certificate_->ShallowCopy();
 }
 
 DOMTimeStamp RTCCertificate::expires() const {
   return static_cast<DOMTimeStamp>(certificate_->Expires());
 }
 
+Vector<v8::Local<v8::Value>> RTCCertificate::fingerprints(
+    ScriptState* script_state) {
+  v8::Isolate* isolate = script_state->GetIsolate();
+  if (fingerprints_.IsEmpty()) {
+    v8::Local<v8::Object> creation_context =
+        script_state->GetContext()->Global();
+    for (const WebRTCDtlsFingerprint& web_fingerprint :
+         certificate_->Fingerprints()) {
+      RTCDtlsFingerprint fingerprint;
+      fingerprint.setAlgorithm(web_fingerprint.Algorithm());

[foolip, 2017/04/21 16:51:53]

Can anything be asserted about the value? Looks per spec like at least they
cannot be empty strings?

[hbos_chromium, 2017/04/24 15:37:54]

Done.

+      fingerprint.setValue(web_fingerprint.Value());
+      fingerprints_.push_back(v8::Global<v8::Value>(
+          isolate, ToV8(fingerprint, creation_context, isolate)));
+    }
+  }
+  Vector<v8::Local<v8::Value>> fingerprints(fingerprints_.size());
+  for (size_t i = 0; i < fingerprints_.size(); ++i) {
+    fingerprints[i] = FreezeV8Object(

[foolip, 2017/04/21 16:51:53]

The members of a FrozenArray shouldn't be frozen, it the array itself that
should be frozen. Can you write a test that checks that the objects in the array
can in fact be modified?

[hbos_chromium, 2017/04/24 15:37:54]

I added tests for this, also regex-testing the fingerprints. I discovered I used
upper-case instead of lower-case and fixed that.

+        v8::Local<v8::Value>::New(isolate, fingerprints_[i]), isolate);
+  }
+  return fingerprints;
+}
+
 }  // namespace blink