Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2828533002: Be tolerant of bad histogram construction arguments. (Closed)

Created:
3 years, 8 months ago by bcwhite
Modified:
3 years, 8 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Be tolerant of bad histogram construction arguments. Even when the definitions for histograms are correct, sometimes the code goes wrong and bad construction arguments appear. This will avoid crashes by adjusting the parameters even on non-DCHECK builds. That doesn't mean that whatever caused the bad parameters to appear hasn't caused other issues as well. BUG=586622 Review-Url: https://codereview.chromium.org/2828533002 Cr-Commit-Position: refs/heads/master@{#467406} Committed: https://chromium.googlesource.com/chromium/src/+/aaf2d3451c0640d07f02978fc35d5119fafc35eb

Patch Set 1 #

Patch Set 2 : fixed signed/unsigned mismatch #

Total comments: 4

Patch Set 3 : Be tolerant of bad histogram construction arguments. #

Total comments: 2

Patch Set 4 : add dummy enum to histogram definition #

Patch Set 5 : revert to older DCHECK locations for compatibility with other modules #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M base/metrics/histogram.h View 1 2 3 4 1 chunk +4 lines, -3 lines 3 comments Download
M base/metrics/histogram.cc View 1 2 3 4 1 chunk +25 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 48 (31 generated)
bcwhite
3 years, 8 months ago (2017-04-18 14:20:17 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/2828533002/diff/20001/base/metrics/histogram.cc File base/metrics/histogram.cc (right): https://codereview.chromium.org/2828533002/diff/20001/base/metrics/histogram.cc#newcode392 base/metrics/histogram.cc:392: if (*bucket_count < 3) This should already be catching ...
3 years, 8 months ago (2017-04-18 19:19:27 UTC) #11
bcwhite
https://codereview.chromium.org/2828533002/diff/20001/base/metrics/histogram.cc File base/metrics/histogram.cc (right): https://codereview.chromium.org/2828533002/diff/20001/base/metrics/histogram.cc#newcode392 base/metrics/histogram.cc:392: if (*bucket_count < 3) On 2017/04/18 19:19:26, Alexei S ...
3 years, 8 months ago (2017-04-18 19:43:26 UTC) #12
bcwhite
https://codereview.chromium.org/2828533002/diff/20001/base/metrics/histogram.cc File base/metrics/histogram.cc (right): https://codereview.chromium.org/2828533002/diff/20001/base/metrics/histogram.cc#newcode392 base/metrics/histogram.cc:392: if (*bucket_count < 3) On 2017/04/18 19:43:26, bcwhite wrote: ...
3 years, 8 months ago (2017-04-24 12:37:59 UTC) #13
Alexei Svitkine (slow)
https://codereview.chromium.org/2828533002/diff/20001/base/metrics/histogram.cc File base/metrics/histogram.cc (right): https://codereview.chromium.org/2828533002/diff/20001/base/metrics/histogram.cc#newcode392 base/metrics/histogram.cc:392: if (*bucket_count < 3) On 2017/04/24 12:37:59, bcwhite wrote: ...
3 years, 8 months ago (2017-04-24 15:45:44 UTC) #14
bcwhite
On 2017/04/24 15:45:44, Alexei Svitkine (slow) wrote: > https://codereview.chromium.org/2828533002/diff/20001/base/metrics/histogram.cc > File base/metrics/histogram.cc (right): > > ...
3 years, 8 months ago (2017-04-24 19:29:38 UTC) #19
Alexei Svitkine (slow)
lg, one comment Thanks! https://codereview.chromium.org/2828533002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2828533002/diff/60001/tools/metrics/histograms/histograms.xml#newcode22307 tools/metrics/histograms/histograms.xml:22307: +<histogram name="Histogram.BadConstructionArguments"> Nit: Add an ...
3 years, 8 months ago (2017-04-24 20:41:20 UTC) #22
bcwhite
https://codereview.chromium.org/2828533002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2828533002/diff/60001/tools/metrics/histograms/histograms.xml#newcode22307 tools/metrics/histograms/histograms.xml:22307: +<histogram name="Histogram.BadConstructionArguments"> On 2017/04/24 20:41:20, Alexei Svitkine (slow) wrote: ...
3 years, 8 months ago (2017-04-24 21:31:39 UTC) #25
Alexei Svitkine (slow)
lgtm Not sure if you need to add a dummy entry or if having it ...
3 years, 8 months ago (2017-04-25 16:30:55 UTC) #28
bcwhite
On 2017/04/25 16:30:55, Alexei Svitkine (slow) wrote: > lgtm > > Not sure if you ...
3 years, 8 months ago (2017-04-26 14:57:09 UTC) #29
Alexei Svitkine (slow)
On 2017/04/26 14:57:09, bcwhite wrote: > On 2017/04/25 16:30:55, Alexei Svitkine (slow) wrote: > > ...
3 years, 8 months ago (2017-04-26 15:01:50 UTC) #30
bcwhite
On 2017/04/26 15:01:50, Alexei Svitkine (slow) wrote: > On 2017/04/26 14:57:09, bcwhite wrote: > > ...
3 years, 8 months ago (2017-04-26 17:27:34 UTC) #38
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2828533002/diff/120001/base/metrics/histogram.h File base/metrics/histogram.h (right): https://codereview.chromium.org/2828533002/diff/120001/base/metrics/histogram.h#newcode187 base/metrics/histogram.h:187: // data doesn't create confusion on the servers. ...
3 years, 8 months ago (2017-04-26 17:33:16 UTC) #39
bcwhite
https://codereview.chromium.org/2828533002/diff/120001/base/metrics/histogram.h File base/metrics/histogram.h (right): https://codereview.chromium.org/2828533002/diff/120001/base/metrics/histogram.h#newcode187 base/metrics/histogram.h:187: // data doesn't create confusion on the servers. On ...
3 years, 8 months ago (2017-04-26 17:47:30 UTC) #40
Alexei Svitkine (slow)
https://codereview.chromium.org/2828533002/diff/120001/base/metrics/histogram.h File base/metrics/histogram.h (right): https://codereview.chromium.org/2828533002/diff/120001/base/metrics/histogram.h#newcode187 base/metrics/histogram.h:187: // data doesn't create confusion on the servers. On ...
3 years, 8 months ago (2017-04-26 17:51:30 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828533002/120001
3 years, 8 months ago (2017-04-26 19:07:55 UTC) #45
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 19:18:07 UTC) #48
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/aaf2d3451c0640d07f02978fc35d...

Powered by Google App Engine
This is Rietveld 408576698