chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc - Issue 282853003: Unmounts volumes before writing to a drive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc

Issue 282853003: Unmounts volumes before writing to a drive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds function comments and reorganizes the unmount operation slightly. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/image_writer_private/error_messages.h » ('j') | chrome/browser/extensions/api/image_writer_private/operation_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc b/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc

index 1ad6d98bc9c1fc6ceddf5613ea898073155691c6..55a146801ad5ce10e62773c828819eb74e8b2766 100644

--- a/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc

+++ b/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc

@@ -10,10 +10,10 @@

namespace extensions {

namespace image_writer {

-// Number of bytes for the maximum partition table size. By wiping this many

-// bytes we can essentially guarantee the header and associated information will

-// be wiped. See http://crbug.com/328246 for more information.

-const int kPartitionTableSize = 1 * 1024;

+// Number of bytes for the maximum partition table size. GUID partition tables

+// reside in the second sector of the disk. Disks can have up to 4k sectors.

+// See http://crbug.com/328246 for more information.

+const int kPartitionTableSize = 2 * 4096;

DestroyPartitionsOperation::DestroyPartitionsOperation(

base::WeakPtr<OperationManager> manager,