Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Issue 282853002: Enable the gyp android build (Closed)

Created:
6 years, 7 months ago by sehr
Modified:
6 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Enable the gyp android build This allows building native client from gyp for Android. To build, you need to check out your client using: gclient sync --deps=android,unix and configure using GYP_DEFINES="OS=android target_arch=arm" gclient runhooks Building by using make will then produce sel_ldr and nacl_helper_bootstrap, which can be run under adb shell. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032 TEST= hello_world_arm_newlib.nexe under adb shell R=bradnelson@google.com, mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13212

Patch Set 1 #

Patch Set 2 : Fixed include path issue for untrusted code #

Patch Set 3 : Clean up nacl_bootstrap conditions #

Patch Set 4 : Make hello world work on Android with the bootstrap loader. #

Patch Set 5 : MOve build to use DEPS-ed in android_tools #

Patch Set 6 : Refactor out android common.gypi parts #

Patch Set 7 : Minor cleanups #

Patch Set 8 : Rebase on top of Roland's CL for AT_BASE #

Total comments: 18

Patch Set 9 : Code review changes #

Patch Set 10 : Remove commented code #

Total comments: 22

Patch Set 11 : Fixes for second round of code review comments #

Total comments: 6

Patch Set 12 : More chromium build/common.gypi commonality #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -97 lines) Patch
A build/android_settings.gypi View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +210 lines, -0 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 8 chunks +28 lines, -10 lines 0 comments Download
M build/untrusted.gypi View 34 chunks +41 lines, -36 lines 0 comments Download
M src/shared/imc/imc.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/shared/platform/nacl_log.c View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/shared/platform/platform.gyp View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M src/trusted/debug_stub/debug_stub.gyp View 1 2 3 4 5 6 7 8 9 10 3 chunks +3 lines, -3 lines 0 comments Download
M src/trusted/desc/desc.gyp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/nonnacl_util/nonnacl_util.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/platform_qualify/platform_qualify.gyp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/sel_universal/parsing.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/linux/nacl_bootstrap.c View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/linux/nacl_bootstrap.gyp View 1 chunk +18 lines, -9 lines 0 comments Download
M src/trusted/service_runtime/linux/nacl_signal.c View 1 2 3 4 5 6 7 8 9 10 1 chunk +6 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 1 2 3 4 5 6 7 8 6 chunks +6 lines, -11 lines 0 comments Download
M tools.gyp View 6 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sehr
Add gyp support to allow building for Android. I liberally cargo-culted the Chrome build/common.gypi setup ...
6 years, 7 months ago (2014-05-15 22:48:19 UTC) #1
Mark Seaborn
Please fill out BUG=, don't just leave it empty. Can you add a TEST= field ...
6 years, 7 months ago (2014-05-15 23:00:52 UTC) #2
sehr
Hopefully better detail. Thanks for the comments. PTAL.
6 years, 7 months ago (2014-05-16 00:26:21 UTC) #3
sehr
Rebased after Roland committed the CL for AT_BASE in nacl_bootstrap.c. PTAL.
6 years, 7 months ago (2014-05-16 17:10:08 UTC) #4
bradn
LGTM with some changes. https://codereview.chromium.org/282853002/diff/140001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/282853002/diff/140001/build/common.gypi#newcode295 build/common.gypi:295: '<(werror)', # See note above ...
6 years, 7 months ago (2014-05-16 18:36:56 UTC) #5
Mark Seaborn
https://codereview.chromium.org/282853002/diff/140001/build/android_settings.gypi File build/android_settings.gypi (right): https://codereview.chromium.org/282853002/diff/140001/build/android_settings.gypi#newcode1 build/android_settings.gypi:1: { Add copyright boilerplate https://codereview.chromium.org/282853002/diff/140001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/282853002/diff/140001/build/common.gypi#newcode291 ...
6 years, 7 months ago (2014-05-16 18:52:58 UTC) #6
sehr
Addressed comments below, and uploaded a new version. PTAL. https://codereview.chromium.org/282853002/diff/140001/build/android_settings.gypi File build/android_settings.gypi (right): https://codereview.chromium.org/282853002/diff/140001/build/android_settings.gypi#newcode1 build/android_settings.gypi:1: ...
6 years, 7 months ago (2014-05-16 23:27:33 UTC) #7
Mark Seaborn
https://codereview.chromium.org/282853002/diff/180001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/282853002/diff/180001/build/common.gypi#newcode299 build/common.gypi:299: # The NDK headers are not compatible with -Wundef ...
6 years, 7 months ago (2014-05-19 17:37:45 UTC) #8
sehr
-Werror change separated out, per Mark's verbal request. New version uploaded. Comments below. https://codereview.chromium.org/282853002/diff/180001/build/common.gypi File ...
6 years, 7 months ago (2014-05-19 20:30:33 UTC) #9
Mark Seaborn
LGTM with passing trybots. https://codereview.chromium.org/282853002/diff/200001/build/android_settings.gypi File build/android_settings.gypi (right): https://codereview.chromium.org/282853002/diff/200001/build/android_settings.gypi#newcode130 build/android_settings.gypi:130: '-I<(android_stlport_include)', Why are -I include ...
6 years, 7 months ago (2014-05-19 21:18:04 UTC) #10
sehr
Thanks again. New version uploaded and trybots are chugging... https://codereview.chromium.org/282853002/diff/200001/build/android_settings.gypi File build/android_settings.gypi (right): https://codereview.chromium.org/282853002/diff/200001/build/android_settings.gypi#newcode130 build/android_settings.gypi:130: ...
6 years, 7 months ago (2014-05-20 05:13:01 UTC) #11
sehr
6 years, 7 months ago (2014-05-20 13:52:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #12 manually as r13212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698