third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2828453002: Add NeedsPreferredWidthsRecalculation() for block

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2828453002: Add NeedsPreferredWidthsRecalculation() for block (Closed)

Patch Set: change commit message Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 4a3b44e41333e018d82cff22aaaea04be9a4d040..de3109daaf9600193b19ef2511010775edf8571b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -605,8 +605,10 @@ void LayoutBlock::UpdateBlockChildDirtyBitsBeforeLayout(bool relayout_children,

// If the child has percentage padding or an embedded content box, we also

// need to invalidate the childs pref widths.

- if (child.NeedsPreferredWidthsRecalculation())

- child.SetPreferredLogicalWidthsDirty(kMarkOnlyThis);

+ if (child.NeedsPreferredWidthsRecalculation()) {

+ child.SetPreferredLogicalWidthsDirty(

+ IsInlineBlockOrInlineTable() ? kMarkContainerChain : kMarkOnlyThis);

mstensho (USE GERRIT) 2017/04/19 10:58:47 Marking the container chain during layout seems wr

+ }

}