third_party/WebKit/LayoutTests/fast/inline-block/inline-block-update-width.html - Issue 2828453002: Add NeedsPreferredWidthsRecalculation() for block

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/inline-block/inline-block-update-width.html

Issue 2828453002: Add NeedsPreferredWidthsRecalculation() for block (Closed)

Patch Set: change commit message Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/inline-block/inline-block-update-width-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #parent {

	4 height: 100px;

	5 }

	6 #container {

	7 display: inline-block;

	8 height: 100%;

	9 }

	10 img {

	11 display: block;

	12 min-height: 100%;

	13 width: auto;
	mstensho (USE GERRIT) 2017/04/19 10:58:47 width and height are initially auto, so no need to width and height are initially auto, so no need to be explicit about it.
	14 height: auto;

	15 }

	16 </style>

	17

	18 <p>

	19 Tests that resizing inline-block container element

	20 when img with width: auto and height: auto resizes

	21 </p>

	22

	23 <div style="height:100px">

	24 <div id="parent">

	25 <div id="container" data-expected-width="25" data-expected-height="50">

	26 <img src='data:image/svg+xml;utf8,<svg height="2px" width="1px" xmlns="htt p://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1 "></svg>'></img>

	27 </div>

	28 </div>

	29 </div>

	30

	31 <script src="../../resources/check-layout.js"></script>
	mstensho (USE GERRIT) 2017/04/19 10:58:47 Please consider using testharness when writing che Please consider using testharness when writing check-layout tests. I.e. include the following scripts instead: <script src="../../resources/testharness.js"></script> <script src="../../resources/testharnessreport.js"></script> <script src="../../resources/check-layout-th.js"></script> That will eliminate the need for the -expected.txt counterpart.
	32

	33 <script>

	34 function runTest() {
	mstensho (USE GERRIT) 2017/04/19 10:58:47 Seems that you can just do all these things right Seems that you can just do all these things right away, rather than hooking them on an onload event. So no need for the wrapper function.
	35 document.body.offsetTop;

	36 var parent = document.getElementById('parent');

	37 parent.style.height = "50px";

	38 document.body.offsetTop;

	39 checkLayout("#container");

	40 }

	41 window.onload = runTest;

	42 </script>

OLD	NEW