Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2058)

Issue 2828443003: NavigationController: broken class invariants (example) (Closed)

Created:
3 years, 8 months ago by arthursonzogni
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, loading-reviews_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

NavigationController: broken class invariants (example) An example of what happens when the {set,Discard}TransientEntry change are removed. This CL is a reply to https://codereview.chromium.org/2810173002/#msg46 NOCOMMIT BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

Patch Set 1 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (9 generated)
arthursonzogni
Description was changed from ========== NavigationController: broken class invariants (example) An example of what happens ...
3 years, 8 months ago (2017-04-18 07:57:28 UTC) #1
arthursonzogni
Description was changed from ========== NavigationController: broken class invariants (example) An example of what happens ...
3 years, 8 months ago (2017-04-18 08:01:22 UTC) #2
arthursonzogni
Description was changed from ========== NavigationController: broken class invariants (example) An example of what happens ...
3 years, 8 months ago (2017-04-18 08:01:56 UTC) #3
arthursonzogni
Patchset #1 (id:1) has been deleted
3 years, 8 months ago (2017-04-18 08:02:11 UTC) #4
arthursonzogni
Patchset #1 (id:20001) has been deleted
3 years, 8 months ago (2017-04-18 08:04:01 UTC) #5
arthursonzogni
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-18 08:04:19 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828443003/40001
3 years, 8 months ago (2017-04-18 08:04:31 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-18 08:34:13 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 08:34:14 UTC) #9
Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698