Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: components/sync/engine_impl/sync_scheduler_impl.h

Issue 2828423002: [Sync] Sync types never recovers from throttle (Closed)
Patch Set: rebase and review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/sync_scheduler_impl.h
diff --git a/components/sync/engine_impl/sync_scheduler_impl.h b/components/sync/engine_impl/sync_scheduler_impl.h
index edf0e1c1904ad484f9ae02124a08631a0f949bcc..67c1cd8cd1e9dae434748ea621571d630cc263d7 100644
--- a/components/sync/engine_impl/sync_scheduler_impl.h
+++ b/components/sync/engine_impl/sync_scheduler_impl.h
@@ -216,6 +216,8 @@ class SyncSchedulerImpl : public SyncScheduler, public base::NonThreadSafe {
// is the most flexible place to do this bookkeeping.
void UpdateNudgeTimeRecords(ModelTypeSet types);
+ bool IsEarlierThanCurrentPendingJob(const base::TimeDelta& delay);
+
// Used for logging.
const std::string name_;
@@ -240,6 +242,8 @@ class SyncSchedulerImpl : public SyncScheduler, public base::NonThreadSafe {
std::unique_ptr<BackoffDelayProvider> delay_provider_;
+ // TODO(gangwu): http://crbug.com/714868 too many timers in this class, try to
+ // reduce them.
// The event that will wake us up.
// When the whole client got throttling or backoff, we will delay this timer
// as well.
« no previous file with comments | « no previous file | components/sync/engine_impl/sync_scheduler_impl.cc » ('j') | components/sync/engine_impl/sync_scheduler_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698