Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2828373002: Revert of Report CHECK/DCHECK to test launcher summary output. (Closed)

Created:
3 years, 8 months ago by krasin1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Report CHECK/DCHECK to test launcher summary output. (patchset #21 id:400001 of https://codereview.chromium.org/2638763004/ ) Reason for revert: Breaks 'LTO Linux' bot: https://build.chromium.org/p/chromium.fyi/builders/LTO%20Linux/builds/2531 Quick investigation revealed, it's official / chrome branded related, not lto related, as LoggingTest.NestedLogAssertHandlers test is failing even if LinkTimeOptimization is explicitly turned off, like with the following gn flags: $ gn gen out/off '--args=is_chrome_branded=true is_official_build=true is_debug=false is_cfi=false use_thin_lto=false allow_posix_link_time_opt=false use_lld=false use_goma=true' --check Original issue's description: > Report CHECK/DCHECK to test launcher summary output. > > This CL is continuation of previous one: > https://codereview.chromium.org/2606153003/ > > BUG= > > Review-Url: https://codereview.chromium.org/2638763004 > Cr-Commit-Position: refs/heads/master@{#465531} > Committed: https://chromium.googlesource.com/chromium/src/+/cc1bde6592ae5e0b5064e7680941569625db9d09 TBR=phajdan.jr@chromium.org,dcheng@chromium.org,brettw@chromium.org,alex-ac@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -234 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/logging.h View 2 chunks +2 lines, -17 lines 0 comments Download
M base/logging.cc View 6 chunks +8 lines, -31 lines 0 comments Download
M base/logging_unittest.cc View 7 chunks +6 lines, -57 lines 0 comments Download
M base/metrics/statistics_recorder_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/strings/string_piece.h View 1 chunk +4 lines, -1 line 0 comments Download
D base/strings/string_piece_forward.h View 1 chunk +0 lines, -23 lines 0 comments Download
M base/test/gtest_xml_unittest_result_printer.h View 2 chunks +1 line, -11 lines 0 comments Download
M base/test/gtest_xml_unittest_result_printer.cc View 5 chunks +7 lines, -19 lines 0 comments Download
M base/test/test_suite.h View 4 chunks +1 line, -11 lines 0 comments Download
M base/test/test_suite.cc View 4 chunks +6 lines, -19 lines 0 comments Download
M chrome/common/logging_chrome.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/collection_view/collection_view_model_unittest.mm View 4 chunks +3 lines, -8 lines 0 comments Download
M net/test/scoped_disable_exit_on_dfatal.h View 1 chunk +4 lines, -6 lines 0 comments Download
M net/test/scoped_disable_exit_on_dfatal.cc View 1 chunk +14 lines, -10 lines 0 comments Download
M net/tools/stress_cache/stress_cache.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M sandbox/linux/tests/main.cc View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
krasin1
Created Revert of Report CHECK/DCHECK to test launcher summary output.
3 years, 8 months ago (2017-04-20 17:39:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828373002/1
3 years, 8 months ago (2017-04-20 17:40:31 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 17:49:39 UTC) #5
Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

Powered by Google App Engine
This is Rietveld 408576698