services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h - Issue 2828333002: Revert of [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h

Issue 2828333002: Revert of [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/common/typemaps.gni ('k') | services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h

diff --git a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h

index 817b667e355f735f5facc8a1888729da5fa399d6..c9c6770b78382ba7a4c0a5424f6f76c7d40b16c9 100644

--- a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h

+++ b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h

@@ -5,9 +5,7 @@

#ifndef SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_MEMORY_INSTRUMENTATION_STRUCT_TRAITS_H_

#define SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_MEMORY_INSTRUMENTATION_STRUCT_TRAITS_H_

-#include "base/process/process_handle.h"

#include "base/trace_event/memory_dump_request_args.h"

-#include "mojo/common/common_custom_types_struct_traits.h"

#include "services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom.h"

namespace mojo {

@@ -97,12 +95,6 @@

const base::trace_event::MemoryDumpCallbackResult& args) {

return args.chrome_dump;

}

- static const std::map<base::ProcessId,

- base::trace_event::MemoryDumpCallbackResult::OSMemDump>&

- extra_processes_dump(

- const base::trace_event::MemoryDumpCallbackResult& args) {

- return args.extra_processes_dump;

- }

static bool Read(

memory_instrumentation::mojom::MemoryDumpCallbackResultDataView input,

base::trace_event::MemoryDumpCallbackResult* out);