Remove obsolete .proto fields

components/policy/proto/device_management_backend.proto

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 
 package enterprise_management;
 
 // Data along with a cryptographic signature verifying their authenticity.
 message SignedData {
   // The data to be signed.
   optional bytes data = 1;
   // The signature of the data field.
   optional bytes signature = 2;
   // How many bytes were added to the end of original data before signature
   // (e.g. a nonce to avoid proxy attacks of the signing service).
   optional int32 extra_data_bytes = 3;
 }
 
 // Request from device to server to register a device, user or browser.
 message DeviceRegisterRequest {
+  reserved 5;
+
   // Reregister device without erasing server state.  It can be used
   // to refresh dmtoken etc.  Client MUST set this value to true if it
   // reuses an existing device id.
   optional bool reregister = 1;
 
   // Register type.  This field does not exist for TT release.
   // When a client requests for policies, server should verify the
   // client has been registered properly.  For example, a client must
   // register with type DEVICE in order to retrieve device policies.
   enum Type {
@@ skipping 11 matching lines @@
 
   // Machine hardware id, such as serial number.
   // This field is required if register type == DEVICE.
   optional string machine_id = 3;
 
   // Machine model name, such as "ZGA", "Cr-48", "Nexus One".  If the
   // model name is not available, client SHOULD send generic name like
   // "Android", or "Chrome OS".
   optional string machine_model = 4;
 
-  // OBSOLETE: Legacy auto-enrollment is not longer supported.
-  optional bool OBSOLETE_auto_enrolled = 5 [deprecated = true];
-
   // Indicates a requisition of the registering entity that the server can act
   // upon. This allows clients to pass hints e.g. at device enrollment time
   // about the intended use of the device.
   optional string requisition = 6;
 
   // The current server-backed state key for the client, if applicable. This can
   // be used by the server to link the registration request to an existing
   // device record for re-enrollment.
   optional bytes server_backed_state_key = 7;
 
@@ skipping 475 matching lines @@
 }
 
 message ActiveTimePeriod {
   optional TimePeriod time_period = 1;
 
   // The active duration during the above time period.
   // The unit is milli-second.
   optional int32 active_duration = 2;
 }
 
-// This captures launch events for one app/extension or other installments.
-message InstallableLaunch {
-  optional string install_id = 1;
-
-  // Time duration where this report covers. These are required
-  // and the record will be ignored if not set.
-  optional TimePeriod duration = 2;
-
-  // Client will send at most 50 timestamps to DM. All the rest
-  // launch activities will be summed into the total count.
-  // We will distribute the count evenly among the time span when
-  // doing time based aggregation.
-  repeated int64 timestamp = 3;
-  optional int64 total_count = 4;
-}
-
-// OBSOLETE: Used to report the device location.
-message OBSOLETE_DeviceLocation {
-  enum ErrorCode {
-    ERROR_CODE_NONE                 = 0;
-    ERROR_CODE_POSITION_UNAVAILABLE = 1;
-  }
-
-  // Latitude in decimal degrees north (WGS84 coordinate frame).
-  optional double latitude = 1;
-
-  // Longitude in decimal degrees west (WGS84 coordinate frame).
-  optional double longitude = 2;
-
-  // Altitude in meters (above WGS84 datum).
-  optional double altitude = 3;
-
-  // Accuracy of horizontal position in meters.
-  optional double accuracy = 4;
-
-  // Accuracy of altitude in meters.
-  optional double altitude_accuracy = 5;
-
-  // Heading in decimal degrees clockwise from true north.
-  optional double heading = 6;
-
-  // Horizontal component of device velocity in meters per second.
-  optional double speed = 7;
-
-  // Time of position measurement in milisecons since Epoch in UTC time.
-  optional int64 timestamp = 8;
-
-  // Error code, see enum above.
-  optional ErrorCode error_code = 9;
-
-  // Human-readable error message.
-  optional string error_message = 10;
-}
-
 // Details about a network interface.
 message NetworkInterface {
   // Indicates the type of network device.
   enum NetworkDeviceType {
     TYPE_ETHERNET = 0;
     TYPE_WIFI = 1;
     TYPE_WIMAX = 2;
     TYPE_BLUETOOTH = 3;
     TYPE_CELLULAR = 4;
   }
@@ skipping 83 matching lines @@
 // Information about a single CPU temperature channel.
 message CPUTempInfo {
   // Temperature channel label.
   optional string cpu_label = 1;
   // CPU temperature in Celsius.
   optional int32 cpu_temp = 2;
 }
 
 // Report device level status.
 message DeviceStatusReportRequest {
+  reserved 4, 7, 13;
+
   // The OS version reported by the device is a platform version
   // e.g. 1435.0.2011_12_16_1635.
   optional string os_version = 1;
   optional string firmware_version = 2;
 
   // "Verified", "Dev". Same as verified mode.
   // If the mode is unknown, this field should not be set.
   optional string boot_mode = 3;
 
-  // OBSOLETE: Device active times collection since last report rpc call.
-  // No longer used -- use active_period instead.
-  repeated TimePeriod OBSOLETE_active_time = 4 [deprecated = true];
-
   // The browser version string as shown in the About dialog.
   // e.g. 17.0.963.18.
   optional string browser_version = 5;
 
   // A list of periods when the device was active, aggregated by day.
   repeated ActiveTimePeriod active_period = 6;
 
-  // OBSOLETE: The device location.
-  optional OBSOLETE_DeviceLocation OBSOLETE_device_location = 7
-    [deprecated = true];
-
   // List of network interfaces.
   repeated NetworkInterface network_interface = 8;
 
   // List of recent device users, in descending order by last login time.
   repeated DeviceUser user = 9;
 
   // Disk space + other info about mounted/connected volumes.
   repeated VolumeInfo volume_info = 10;
 
   // List of visible/configured networks
   repeated NetworkState network_state = 11;
 
   // Samples of CPU utilization (0-100), sampled once every 120 seconds.
   repeated int32 cpu_utilization_pct = 12;
 
-  // OBSOLETE: Free RAM (unreliable due to GC).
-  optional int64 OBSOLETE_system_ram_free = 13 [deprecated = true];
-
   // Total RAM on the device.
   optional int64 system_ram_total = 14;
 
   // Samples of free RAM [in bytes] (unreliable due to GC).
   repeated int64 system_ram_free = 15;
 
   // Samples of CPU temperatures in Celsius, plus associated labels
   // identifying which CPU produced the temperature measurement.
   repeated CPUTempInfo cpu_temp_info = 16;
 
@@ skipping 51 matching lines @@
 
 message AndroidStatus {
   // JSON string of ARC status report.
   optional string status_payload = 1;
   // DroidGuard response obtained from DroidGuard server.
   optional string droid_guard_info = 2;
 }
 
 // Report current active session (a user on one device) level status.
 message SessionStatusReportRequest {
-  // OBSOLETE: Installed apps for this user on this device.
-  // No longer used -- use installed_apps instead.
-  repeated string OBSOLETE_installed_app_id = 1 [deprecated = true];
-
-  // OBSOLETE: Installed extensions for this user on this device.
-  // No longer used -- use installed_extensions instead.
-  repeated string OBSOLETE_installed_extension_id = 2 [deprecated = true];
-
-  // One stat per app for top 30 apps.
-  repeated InstallableLaunch app_launch_stat = 3;

[emaxx, 2017/04/20 16:59:02]

Just a note: I think we should be careful with removing not deprecated
fields/messages straight away. For instance, maybe they are laid here as a
schema for the to-be-implemented communications.
Though it seems that the fields deleted in this CL are not referenced anywhere,
including the server side code base, and are not mentioned in any plans or
design docs for the future.
So I'm fine with performing this removal.

[Thiemo Nagel, 2017/04/21 09:48:27]

Thanks, I guess it's fair game to take a look whether something is part of an
ongoing implementation, but if that's not the case I'd rather remove it (and
potentially add it back later).  Imho the same rules as for code should apply:
If it's unused, it either must get used (soon) or it must go away.

+  reserved 1, 2, 3, 6;
 
   // If this is a kiosk session, this is the device local account ID.
   optional string device_local_account_id = 4;
 
   // Information about installed apps for this user on this device.
   repeated AppStatus installed_apps = 5;
 
-  // Information about installed extensions for this user on this device.
-  repeated AppStatus installed_extensions = 6;
-
   // Information about ARC status.
   optional AndroidStatus android_status = 7;
 
   // If this is a regular user session, this is the user's DMToken.
   optional string user_dm_token = 8;
 }
 
 // Response from DMServer to update devices' status.
 // It is possible that status report fails but policy request succeed.  In such
 // case, the DeviceStatusReportResponse will contain an error code and the
@@ skipping 630 matching lines @@
       check_android_management_response = 18;
 
   // Response to an Active Directory Play user enrollment request.
   optional ActiveDirectoryEnrollPlayUserResponse
       active_directory_enroll_play_user_response = 19;
 
   // Response to a Play activity request.
   optional ActiveDirectoryPlayActivityResponse
       active_directory_play_activity_response = 20;
 }