Track execution phase of browser process when we log if the broswer has

Track execution phase of browser process and track it as
a UMA histogram.

As a first attempt, tracked the following 

- Before starting metrics service,
- Before creating profile
- Before starting startup time bomb
- Before starting thread watcher
- Before starting main message loop
- Before starting shutdown time bomb
- clean shutdown.

R=jar@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231334

[ramant (doing other things), 2013-10-21 18:31:33]

Hi Jim,
  This is the first attempt at tracking the execution phase the browser is in.
In this CL, saving the execution phase in the prefs file (ala
kStabilityExitedCleanly pref). For windows, if we were to track other execution
phases, will move saving and getting the preference from the registry.

  Would appreciate if you could take a look.

thanks
raman

[jar (doing other things), 2013-10-26 02:09:20]

LGTM % small comment below.

https://codereview.chromium.org/28283002/diff/30001/chrome/browser/metrics/me...
File chrome/browser/metrics/metrics_service.cc (right):

https://codereview.chromium.org/28283002/diff/30001/chrome/browser/metrics/me...
chrome/browser/metrics/metrics_service.cc:912:
pref->SetInteger(prefs::kStabilityExecutionPhase, CLEAN_SHUTDOWN);
Perhaps this block from lines 908 to 912 should be inside the if() block ending
at 906.

It may not be a big deal... but we can probably avoid making the histogram when
we don't have a dirty shutdown to talk about...

...plus....

We're most concerned these days about what caused a dirty shutdown.

WDYT?

[ramant (doing other things), 2013-10-26 03:29:35]

https://codereview.chromium.org/28283002/diff/30001/chrome/browser/metrics/me...
File chrome/browser/metrics/metrics_service.cc (right):

https://codereview.chromium.org/28283002/diff/30001/chrome/browser/metrics/me...
chrome/browser/metrics/metrics_service.cc:912:
pref->SetInteger(prefs::kStabilityExecutionPhase, CLEAN_SHUTDOWN);
On 2013/10/26 02:09:21, jar wrote:
> Perhaps this block from lines 908 to 912 should be inside the if() block
ending
> at 906.
> 
> It may not be a big deal... but we can probably avoid making the histogram
when
> we don't have a dirty shutdown to talk about...
> 
> ...plus....
> 
> We're most concerned these days about what caused a dirty shutdown.
> 
> WDYT?

Done.

[commit-bot: I haz the power, 2013-10-26 03:29:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/28283002/260001

[commit-bot: I haz the power, 2013-10-26 04:11:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/28283002/260001

[commit-bot: I haz the power, 2013-10-26 04:31:41]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[ramant (doing other things), 2013-10-26 14:32:12]

Hi Nico,
  Could you please take a look at this change and give owners approval?

thanks,
raman

[ramant (doing other things), 2013-10-27 23:47:46]

Hi ananta,
  Could you please review chrome_frame changes?
thanks
raman

[Nico, 2013-10-28 01:46:52]

pref_names, chrome_browser_main lgtm

[commit-bot: I haz the power, 2013-10-28 02:30:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/28283002/260001

[commit-bot: I haz the power, 2013-10-28 02:48:09]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[grt (UTC plus 2), 2013-10-28 13:44:12]

chrome_frame/* lgtm

[commit-bot: I haz the power, 2013-10-28 13:44:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/28283002/260001

[ramant (doing other things), 2013-10-28 14:18:22]

On 2013/10/28 13:44:12, grt wrote:
> chrome_frame/* lgtm

thanks very much grt and Nico.

[commit-bot: I haz the power, 2013-10-28 15:58:22]

Change committed as 231334