Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2828273003: Prepare to publish analyzer, front_end, and kernel. (Closed)

Created:
3 years, 8 months ago by Paul Berry
Modified:
3 years, 8 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Brian Wilkerson, danrubel
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prepare to publish analyzer, front_end, and kernel. Due to the tight coupling between analyzer and front_end, they need to be published atomically. The last published version of kernel is old enough that it needs to be published too. I've bumped the versions to the following, and changed the dependencies so that this set of versions is mutually compatible: - analyzer: 0.30.0-alpha.3 - front_end: 0.1.0-alpha.2 - kernel: 0.2.0 (Note that kernel's version didn't need bumping since the most recently published version of it is 0.1.0) R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/3dbe0099a249247c14f38301ccf3dfaeee97fe3c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M pkg/analyzer/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/pubspec.yaml View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/kernel/pubspec.yaml View 2 chunks +2 lines, -3 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Paul Berry
3 years, 8 months ago (2017-04-21 08:15:58 UTC) #2
asgerf
LGTM. I have a comment, but I am OK with landing as-is to unblock downstream ...
3 years, 8 months ago (2017-04-21 08:25:56 UTC) #3
Paul Berry
https://codereview.chromium.org/2828273003/diff/1/pkg/kernel/pubspec.yaml File pkg/kernel/pubspec.yaml (right): https://codereview.chromium.org/2828273003/diff/1/pkg/kernel/pubspec.yaml#newcode16 pkg/kernel/pubspec.yaml:16: test: ^0.12.15+6 On 2017/04/21 08:25:56, asgerf wrote: > Did ...
3 years, 8 months ago (2017-04-21 08:34:58 UTC) #4
Paul Berry
Committed patchset #1 (id:1) manually as 3dbe0099a249247c14f38301ccf3dfaeee97fe3c (presubmit successful).
3 years, 8 months ago (2017-04-21 08:35:41 UTC) #6
Paul Berry
On 2017/04/21 08:34:58, Paul Berry wrote: > https://codereview.chromium.org/2828273003/diff/1/pkg/kernel/pubspec.yaml > File pkg/kernel/pubspec.yaml (right): > > https://codereview.chromium.org/2828273003/diff/1/pkg/kernel/pubspec.yaml#newcode16 ...
3 years, 8 months ago (2017-04-21 08:57:22 UTC) #7
Siggi Cherem (dart-lang)
3 years, 8 months ago (2017-04-21 16:12:59 UTC) #8
Message was sent while issue was closed.
On 2017/04/21 08:57:22, Paul Berry wrote:
> On 2017/04/21 08:34:58, Paul Berry wrote:
> > https://codereview.chromium.org/2828273003/diff/1/pkg/kernel/pubspec.yaml
> > File pkg/kernel/pubspec.yaml (right):
> > 
> >
>
https://codereview.chromium.org/2828273003/diff/1/pkg/kernel/pubspec.yaml#new...
> > pkg/kernel/pubspec.yaml:16: test: ^0.12.15+6
> > On 2017/04/21 08:25:56, asgerf wrote:
> > > Should we just not declare our dev_dependencies in the first place? AFAIK
> > there
> > > is no way to develop kernel outside of the SDK.
> > 
> > That's a really good point.  I'll open up an email discussion about that.
> 
> On further reflection, I think that front_end and analyzer also only make
sense
> to develop within the SDK.  So we don't really need to worry about having a
set
> of mutually compatiable versions listed in dev_dependencies, because no one is
> going to run "pub get" in one of these directories and expect to be able to do
> development work.
> 
> However, I think listing the dev_dependencies is still useful documentation,
and
> it has the nice effect of suppressing annoying warnings from "pub publish". 
So
> I think I'll go ahead and leave the dependencies in place.

what about listing these as "any"? That way we don't have to update the
dev_dependencies that often.

Powered by Google App Engine
This is Rietveld 408576698