Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 282823004: Remove internalSubset from DocumentType (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
CC:
blink-reviews, eustas+blink_chromium.org, caseq+blink_chromium.org, arv+blink, pfeldman+blink_chromium.org, malch+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, loislo+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove internalSubset from DocumentType Remove internalSubset from DocumentType, since even though it is being read in MarkupAccumulator it is not being set anywhere, and also it is scheduled to be removed from latest DOM spec. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174043

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove corresponding use counter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M Source/core/dom/DocumentType.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentType.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
PTAL, it seems safe to remove but may need an Intent to remove? According to ...
6 years, 7 months ago (2014-05-14 15:57:58 UTC) #1
arv (Not doing code reviews)
LGTM The use counter shows 0.0004% Since it was never set the value was exposed ...
6 years, 7 months ago (2014-05-14 16:58:05 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-05-14 17:12:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/282823004/20001
6 years, 7 months ago (2014-05-14 17:12:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 18:22:03 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 18:59:05 UTC) #6
Message was sent while issue was closed.
Change committed as 174043

Powered by Google App Engine
This is Rietveld 408576698