components/favicon/core/favicon_service_impl.h - Issue 2828173002: [Refactor] Simplify HistoryBackend::UpdateFaviconMappingsAndFetchImpl() signature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_service_impl.h

Issue 2828173002: [Refactor] Simplify HistoryBackend::UpdateFaviconMappingsAndFetchImpl() signature (Closed)

Patch Set: Merge branch 'master' into icon_type0 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_service_impl.h

diff --git a/components/favicon/core/favicon_service_impl.h b/components/favicon/core/favicon_service_impl.h

index d7e5c308823cf1e531b1382c1f95a6ef7dddee17..e1cb63c4b08522a0f53cf8b8aa0c5ec9ac025dde 100644

--- a/components/favicon/core/favicon_service_impl.h

+++ b/components/favicon/core/favicon_service_impl.h

@@ -81,8 +81,8 @@ class FaviconServiceImpl : public FaviconService {

base::CancelableTaskTracker* tracker) override;

base::CancelableTaskTracker::TaskId UpdateFaviconMappingsAndFetch(

const GURL& page_url,

- const std::vector<GURL>& icon_urls,

- int icon_types,

+ const GURL& icon_url,

+ favicon_base::IconType icon_type,

int desired_size_in_dip,

const favicon_base::FaviconResultsCallback& callback,

base::CancelableTaskTracker* tracker) override;