Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: components/favicon/core/favicon_service_impl.cc

Issue 2828173002: [Refactor] Simplify HistoryBackend::UpdateFaviconMappingsAndFetchImpl() signature (Closed)
Patch Set: Merge branch 'master' into icon_type0 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/favicon/core/favicon_service_impl.h" 5 #include "components/favicon/core/favicon_service_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <cmath> 8 #include <cmath>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 FaviconServiceImpl::~FaviconServiceImpl() {} 66 FaviconServiceImpl::~FaviconServiceImpl() {}
67 67
68 base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetFaviconImage( 68 base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetFaviconImage(
69 const GURL& icon_url, 69 const GURL& icon_url,
70 const favicon_base::FaviconImageCallback& callback, 70 const favicon_base::FaviconImageCallback& callback,
71 base::CancelableTaskTracker* tracker) { 71 base::CancelableTaskTracker* tracker) {
72 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFaviconImage"); 72 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFaviconImage");
73 favicon_base::FaviconResultsCallback callback_runner = 73 favicon_base::FaviconResultsCallback callback_runner =
74 base::Bind(&FaviconServiceImpl::RunFaviconImageCallbackWithBitmapResults, 74 base::Bind(&FaviconServiceImpl::RunFaviconImageCallbackWithBitmapResults,
75 base::Unretained(this), callback, gfx::kFaviconSize); 75 base::Unretained(this), callback, gfx::kFaviconSize);
76 std::vector<GURL> icon_urls; 76 return history_service_->GetFavicon(
77 icon_urls.push_back(icon_url); 77 icon_url, favicon_base::FAVICON,
78 return history_service_->GetFavicons(
79 icon_urls, favicon_base::FAVICON,
80 GetPixelSizesForFaviconScales(gfx::kFaviconSize), callback_runner, 78 GetPixelSizesForFaviconScales(gfx::kFaviconSize), callback_runner,
81 tracker); 79 tracker);
82 } 80 }
83 81
84 base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetRawFavicon( 82 base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetRawFavicon(
85 const GURL& icon_url, 83 const GURL& icon_url,
86 favicon_base::IconType icon_type, 84 favicon_base::IconType icon_type,
87 int desired_size_in_pixel, 85 int desired_size_in_pixel,
88 const favicon_base::FaviconRawBitmapCallback& callback, 86 const favicon_base::FaviconRawBitmapCallback& callback,
89 base::CancelableTaskTracker* tracker) { 87 base::CancelableTaskTracker* tracker) {
90 TRACE_EVENT0("browser", "FaviconServiceImpl::GetRawFavicon"); 88 TRACE_EVENT0("browser", "FaviconServiceImpl::GetRawFavicon");
91 favicon_base::FaviconResultsCallback callback_runner = base::Bind( 89 favicon_base::FaviconResultsCallback callback_runner = base::Bind(
92 &FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults, 90 &FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults,
93 base::Unretained(this), callback, desired_size_in_pixel); 91 base::Unretained(this), callback, desired_size_in_pixel);
94 92
95 std::vector<GURL> icon_urls;
96 icon_urls.push_back(icon_url);
97 std::vector<int> desired_sizes_in_pixel; 93 std::vector<int> desired_sizes_in_pixel;
98 desired_sizes_in_pixel.push_back(desired_size_in_pixel); 94 desired_sizes_in_pixel.push_back(desired_size_in_pixel);
99 95
100 return history_service_->GetFavicons( 96 return history_service_->GetFavicon(
101 icon_urls, icon_type, desired_sizes_in_pixel, callback_runner, tracker); 97 icon_url, icon_type, desired_sizes_in_pixel, callback_runner, tracker);
102 } 98 }
103 99
104 base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetFavicon( 100 base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetFavicon(
105 const GURL& icon_url, 101 const GURL& icon_url,
106 favicon_base::IconType icon_type, 102 favicon_base::IconType icon_type,
107 int desired_size_in_dip, 103 int desired_size_in_dip,
108 const favicon_base::FaviconResultsCallback& callback, 104 const favicon_base::FaviconResultsCallback& callback,
109 base::CancelableTaskTracker* tracker) { 105 base::CancelableTaskTracker* tracker) {
110 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFavicon"); 106 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFavicon");
111 std::vector<GURL> icon_urls; 107 std::vector<GURL> icon_urls;
112 icon_urls.push_back(icon_url); 108 icon_urls.push_back(icon_url);
113 return history_service_->GetFavicons( 109 return history_service_->GetFavicon(
114 icon_urls, icon_type, GetPixelSizesForFaviconScales(desired_size_in_dip), 110 icon_url, icon_type, GetPixelSizesForFaviconScales(desired_size_in_dip),
115 callback, tracker); 111 callback, tracker);
116 } 112 }
117 113
118 base::CancelableTaskTracker::TaskId 114 base::CancelableTaskTracker::TaskId
119 FaviconServiceImpl::GetFaviconImageForPageURL( 115 FaviconServiceImpl::GetFaviconImageForPageURL(
120 const GURL& page_url, 116 const GURL& page_url,
121 const favicon_base::FaviconImageCallback& callback, 117 const favicon_base::FaviconImageCallback& callback,
122 base::CancelableTaskTracker* tracker) { 118 base::CancelableTaskTracker* tracker) {
123 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFaviconImageForPageURL"); 119 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFaviconImageForPageURL");
124 return GetFaviconForPageURLImpl( 120 return GetFaviconForPageURLImpl(
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 base::CancelableTaskTracker* tracker) { 171 base::CancelableTaskTracker* tracker) {
176 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFaviconForPageURL"); 172 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFaviconForPageURL");
177 return GetFaviconForPageURLImpl( 173 return GetFaviconForPageURLImpl(
178 page_url, icon_types, GetPixelSizesForFaviconScales(desired_size_in_dip), 174 page_url, icon_types, GetPixelSizesForFaviconScales(desired_size_in_dip),
179 callback, tracker); 175 callback, tracker);
180 } 176 }
181 177
182 base::CancelableTaskTracker::TaskId 178 base::CancelableTaskTracker::TaskId
183 FaviconServiceImpl::UpdateFaviconMappingsAndFetch( 179 FaviconServiceImpl::UpdateFaviconMappingsAndFetch(
184 const GURL& page_url, 180 const GURL& page_url,
185 const std::vector<GURL>& icon_urls, 181 const GURL& icon_url,
186 int icon_types, 182 favicon_base::IconType icon_type,
187 int desired_size_in_dip, 183 int desired_size_in_dip,
188 const favicon_base::FaviconResultsCallback& callback, 184 const favicon_base::FaviconResultsCallback& callback,
189 base::CancelableTaskTracker* tracker) { 185 base::CancelableTaskTracker* tracker) {
190 return history_service_->UpdateFaviconMappingsAndFetch( 186 return history_service_->UpdateFaviconMappingsAndFetch(
191 page_url, icon_urls, icon_types, 187 page_url, icon_url, icon_type,
192 GetPixelSizesForFaviconScales(desired_size_in_dip), callback, tracker); 188 GetPixelSizesForFaviconScales(desired_size_in_dip), callback, tracker);
193 } 189 }
194 190
195 base::CancelableTaskTracker::TaskId 191 base::CancelableTaskTracker::TaskId
196 FaviconServiceImpl::GetLargestRawFaviconForID( 192 FaviconServiceImpl::GetLargestRawFaviconForID(
197 favicon_base::FaviconID favicon_id, 193 favicon_base::FaviconID favicon_id,
198 const favicon_base::FaviconRawBitmapCallback& callback, 194 const favicon_base::FaviconRawBitmapCallback& callback,
199 base::CancelableTaskTracker* tracker) { 195 base::CancelableTaskTracker* tracker) {
200 TRACE_EVENT0("browser", "FaviconServiceImpl::GetLargestRawFaviconForID"); 196 TRACE_EVENT0("browser", "FaviconServiceImpl::GetLargestRawFaviconForID");
201 // Use 0 as |desired_size| to get the largest bitmap for |favicon_id| without 197 // Use 0 as |desired_size| to get the largest bitmap for |favicon_id| without
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 const std::vector<favicon_base::FaviconRawBitmapResult>& 297 const std::vector<favicon_base::FaviconRawBitmapResult>&
302 favicon_bitmap_results) { 298 favicon_bitmap_results) {
303 TRACE_EVENT0( 299 TRACE_EVENT0(
304 "browser", 300 "browser",
305 "FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults"); 301 "FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults");
306 callback.Run( 302 callback.Run(
307 ResizeFaviconBitmapResult(favicon_bitmap_results, desired_size_in_pixel)); 303 ResizeFaviconBitmapResult(favicon_bitmap_results, desired_size_in_pixel));
308 } 304 }
309 305
310 } // namespace favicon 306 } // namespace favicon
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698