Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: net/quic/core/congestion_control/bbr_sender_test.cc

Issue 2828163005: Convert QUIC non-feature flags to the old syntax, for consistency. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/congestion_control/bbr_sender.cc ('k') | net/quic/core/quic_version_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/congestion_control/bbr_sender_test.cc
diff --git a/net/quic/core/congestion_control/bbr_sender_test.cc b/net/quic/core/congestion_control/bbr_sender_test.cc
index de61b8c50ebb5ca7df1ac4bf5ec1a70030728774..872b863460548ab1f64fc2589ca14a3460bb4ec3 100644
--- a/net/quic/core/congestion_control/bbr_sender_test.cc
+++ b/net/quic/core/congestion_control/bbr_sender_test.cc
@@ -350,7 +350,7 @@ TEST_F(BbrSenderTest, SimpleTransfer2RTTAggregationKeepSending) {
TEST_F(BbrSenderTest, SimpleTransferAckDecimation) {
FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes = true;
// Decrease the CWND gain so extra CWND is required with stretch acks.
- SetQuicFlag(&FLAGS_quic_bbr_cwnd_gain, 1.0);
+ FLAGS_quic_bbr_cwnd_gain = 1.0;
sender_ = new BbrSender(
rtt_stats_,
QuicSentPacketManagerPeer::GetUnackedPacketMap(
@@ -387,7 +387,7 @@ TEST_F(BbrSenderTest, SimpleTransferAckDecimationKeepSending) {
FLAGS_quic_reloadable_flag_quic_bbr_add_tso_cwnd = true;
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate = true;
// Decrease the CWND gain so extra CWND is required with stretch acks.
- SetQuicFlag(&FLAGS_quic_bbr_cwnd_gain, 1.0);
+ FLAGS_quic_bbr_cwnd_gain = 1.0;
sender_ = new BbrSender(
rtt_stats_,
QuicSentPacketManagerPeer::GetUnackedPacketMap(
@@ -426,8 +426,8 @@ TEST_F(BbrSenderTest,
FLAGS_quic_reloadable_flag_quic_bbr_add_tso_cwnd = false;
FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate = false;
FLAGS_quic_reloadable_flag_quic_bbr_slow_recent_delivery = true;
- SetQuicFlag(&FLAGS_quic_bbr_slow_delivery_threshold_multiplier, 0.5);
- SetQuicFlag(&FLAGS_quic_bbr_slow_delivery_cwnd_gain, 4.0);
+ FLAGS_quic_bbr_slow_delivery_threshold_multiplier = 0.5;
+ FLAGS_quic_bbr_slow_delivery_cwnd_gain = 4.0;
CreateDefaultSetup();
// 2 RTTs of aggregation, with a max of 10kb.
EnableAggregation(10 * 1024, 2 * kTestRtt);
« no previous file with comments | « net/quic/core/congestion_control/bbr_sender.cc ('k') | net/quic/core/quic_version_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698