Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: net/quic/core/quic_versions_test.cc

Issue 2828163005: Convert QUIC non-feature flags to the old syntax, for consistency. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/core/quic_versions.cc ('k') | net/tools/quic/quic_dispatcher_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/quic_versions.h" 5 #include "net/quic/core/quic_versions.h"
6 6
7 #include "net/quic/platform/api/quic_flags.h" 7 #include "net/quic/platform/api/quic_flags.h"
8 #include "net/quic/test_tools/quic_test_utils.h" 8 #include "net/quic/test_tools/quic_test_utils.h"
9 #include "testing/gmock/include/gmock/gmock.h" 9 #include "testing/gmock/include/gmock/gmock.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 EXPECT_EQ(QUIC_VERSION_36, filtered_versions[1]); 140 EXPECT_EQ(QUIC_VERSION_36, filtered_versions[1]);
141 EXPECT_EQ(QUIC_VERSION_37, filtered_versions[2]); 141 EXPECT_EQ(QUIC_VERSION_37, filtered_versions[2]);
142 } 142 }
143 143
144 TEST(QuicVersionsTest, FilterSupportedVersionsNo39) { 144 TEST(QuicVersionsTest, FilterSupportedVersionsNo39) {
145 QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36, 145 QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
146 QUIC_VERSION_37, QUIC_VERSION_38, 146 QUIC_VERSION_37, QUIC_VERSION_38,
147 QUIC_VERSION_39}; 147 QUIC_VERSION_39};
148 148
149 FLAGS_quic_reloadable_flag_quic_enable_version_38 = true; 149 FLAGS_quic_reloadable_flag_quic_enable_version_38 = true;
150 SetQuicFlag(&FLAGS_quic_enable_version_39, false); 150 FLAGS_quic_enable_version_39 = false;
151 151
152 QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions); 152 QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions);
153 ASSERT_EQ(4u, filtered_versions.size()); 153 ASSERT_EQ(4u, filtered_versions.size());
154 EXPECT_EQ(QUIC_VERSION_35, filtered_versions[0]); 154 EXPECT_EQ(QUIC_VERSION_35, filtered_versions[0]);
155 EXPECT_EQ(QUIC_VERSION_36, filtered_versions[1]); 155 EXPECT_EQ(QUIC_VERSION_36, filtered_versions[1]);
156 EXPECT_EQ(QUIC_VERSION_37, filtered_versions[2]); 156 EXPECT_EQ(QUIC_VERSION_37, filtered_versions[2]);
157 EXPECT_EQ(QUIC_VERSION_38, filtered_versions[3]); 157 EXPECT_EQ(QUIC_VERSION_38, filtered_versions[3]);
158 } 158 }
159 159
160 TEST(QuicVersionsTest, FilterSupportedVersionsAllVersions) { 160 TEST(QuicVersionsTest, FilterSupportedVersionsAllVersions) {
161 QuicFlagSaver flags; 161 QuicFlagSaver flags;
162 QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36, 162 QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
163 QUIC_VERSION_37, QUIC_VERSION_38, 163 QUIC_VERSION_37, QUIC_VERSION_38,
164 QUIC_VERSION_39}; 164 QUIC_VERSION_39};
165 165
166 FLAGS_quic_reloadable_flag_quic_enable_version_38 = true; 166 FLAGS_quic_reloadable_flag_quic_enable_version_38 = true;
167 SetQuicFlag(&FLAGS_quic_enable_version_39, true); 167 FLAGS_quic_enable_version_39 = true;
168 168
169 QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions); 169 QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions);
170 ASSERT_EQ(all_versions, filtered_versions); 170 ASSERT_EQ(all_versions, filtered_versions);
171 } 171 }
172 172
173 TEST(QuicVersionsTest, LookUpVersionByIndex) { 173 TEST(QuicVersionsTest, LookUpVersionByIndex) {
174 QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36, 174 QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
175 QUIC_VERSION_37, QUIC_VERSION_38, 175 QUIC_VERSION_37, QUIC_VERSION_38,
176 QUIC_VERSION_39}; 176 QUIC_VERSION_39};
177 int version_count = all_versions.size(); 177 int version_count = all_versions.size();
178 for (int i = -5; i <= version_count + 1; ++i) { 178 for (int i = -5; i <= version_count + 1; ++i) {
179 if (i >= 0 && i < version_count) { 179 if (i >= 0 && i < version_count) {
180 EXPECT_EQ(all_versions[i], VersionOfIndex(all_versions, i)[0]); 180 EXPECT_EQ(all_versions[i], VersionOfIndex(all_versions, i)[0]);
181 } else { 181 } else {
182 EXPECT_EQ(QUIC_VERSION_UNSUPPORTED, VersionOfIndex(all_versions, i)[0]); 182 EXPECT_EQ(QUIC_VERSION_UNSUPPORTED, VersionOfIndex(all_versions, i)[0]);
183 } 183 }
184 } 184 }
185 } 185 }
186 186
187 } // namespace 187 } // namespace
188 } // namespace test 188 } // namespace test
189 } // namespace net 189 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/core/quic_versions.cc ('k') | net/tools/quic/quic_dispatcher_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698