chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc - Issue 2828163004: Revert of Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

Issue 2828163004: Revert of Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/drive/drive_app_provider_browsertest.cc ('k') | chrome/browser/chromeos/login/login_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

diff --git a/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc b/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

index c3109b0ffe0d3ef7eed85d34abdf91a26e407759..01008ae629792fcc886525527fe5615ab92c31ae 100644

--- a/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

+++ b/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

@@ -312,8 +312,10 @@

loader_->StopCache(shutdown_run_loop.QuitClosure());

VerifyAndResetVisitorCallExpectations();

- // Spin the loop until the cache shutdown callback is invoked.

+ // Spin the loop until the cache shutdown callback is invoked. Verify that at

+ // that point, no further file I/O tasks are pending.

shutdown_run_loop.Run();

+ EXPECT_TRUE(base::MessageLoop::current()->IsIdleForTesting());

}

} // namespace chromeos

« no previous file with comments | « chrome/browser/apps/drive/drive_app_provider_browsertest.cc ('k') | chrome/browser/chromeos/login/login_manager_test.cc » ('j') | no next file with comments »