Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8828)

Unified Diff: chrome/test/BUILD.gn

Issue 2828143007: Attempt to disable tab_capture_end2end_tests on the trybots. (Closed)
Patch Set: remove test.gni revert Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/gn_isolate_map.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 8e54d5edb58e330a3a7a9d49d7b2a37f6377b3bd..9d026ee2bcb6c0f1cbe96e68ef6b03f934cb1107 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -1136,12 +1136,17 @@ if (!is_android) {
]
}
- # TODO(GYP_GONE): Delete this after we've converted everything to GN.
- # This target exist only for compatibility w/ GYP.
+ # TODO(dpranke), TODO(crbug.com/714336): tab_capture_end2end_tests
+ # is really just browser_tests with some different flags. Figure out
+ # what the right way to run this is given the different ways to
+ # configure things in the //testing/buildbot/*.json files, here,
+ # gn_isolate_map.pyl, and mb.py. There's too many knobs and the interaction
+ # is strange and unclear at this point. For now, I *think* this will just
+ # have the effect of disabling the test in analyze. :(.
group("tab_capture_end2end_tests") {
testonly = true
deps = [
- ":browser_tests",
+ # ":browser_tests",
]
}
}
« no previous file with comments | « no previous file | testing/buildbot/gn_isolate_map.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698