Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2828103002: Now that contextRoot is within the is check, don't need contextRoot at all (Closed)

Created:
3 years, 8 months ago by mfairhurst
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Now that contextRoot is within the is check, don't need contextRoot at all BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/746fd353072bf6df30c534991758477e99f64349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mfairhurst
This will let us make our master branch of analyzer compatible with both the dev ...
3 years, 8 months ago (2017-04-19 22:21:52 UTC) #2
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-19 22:44:29 UTC) #3
mfairhurst
3 years, 8 months ago (2017-04-19 22:45:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
746fd353072bf6df30c534991758477e99f64349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698