third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2828093003: updating Input field value by script should reset IME composition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2828093003: updating Input field value by script should reset IME composition. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index bca08c29a4491a97c0e211b648a6013629bbbb4f..3e5e433e9dfc594057aee81a6e4b475e4b4ce0c4 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -1755,6 +1755,7 @@ void Editor::RespondToChangedSelection(

const Position& old_selection_start,

FrameSelection::SetSelectionOptions options) {

GetSpellChecker().RespondToChangedSelection(old_selection_start, options);

+ GetFrame().GetInputMethodController().CancelCompositionIfSelectionIsInvalid();

Client().RespondToChangedSelection(&GetFrame(),

GetFrame()

.Selection()