Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: chrome/browser/browsing_data/passwords_counter_browsertest.cc

Issue 2828083003: Show autofill sync status in CBD (Closed)
Patch Set: fix history test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/passwords_counter_browsertest.cc
diff --git a/chrome/browser/browsing_data/passwords_counter_browsertest.cc b/chrome/browser/browsing_data/passwords_counter_browsertest.cc
index 38d647ff2ac1f1fb04a9720c9cf012e6e887beef..b831cb79031308894e67ca956aff0c830d754279 100644
--- a/chrome/browser/browsing_data/passwords_counter_browsertest.cc
+++ b/chrome/browser/browsing_data/passwords_counter_browsertest.cc
@@ -332,12 +332,15 @@ IN_PROC_BROWSER_TEST_F(PasswordsCounterTest, RestartOnSyncChange) {
// We stop syncing passwords in particular. This restarts the counter.
syncer::ModelTypeSet everything_except_passwords =
- syncer::ModelTypeSet::All();
+ syncer::UserSelectableTypes();
everything_except_passwords.Remove(syncer::PASSWORDS);
auto sync_blocker = sync_service->GetSetupInProgressHandle();
- sync_service->ChangePreferredDataTypes(everything_except_passwords);
+ sync_service->OnUserChoseDatatypes(/*sync_everything=*/false,
+ everything_except_passwords);
+ ASSERT_FALSE(sync_service->GetPreferredDataTypes().Has(syncer::PASSWORDS));
sync_blocker.reset();
WaitForCountingOrConfirmFinished();
+ ASSERT_FALSE(sync_service->GetPreferredDataTypes().Has(syncer::PASSWORDS));
EXPECT_FALSE(PasswordSyncEnabled());
// If password sync is not affected, the counter is not restarted.

Powered by Google App Engine
This is Rietveld 408576698