Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 282803002: Update perf expectations for linux/mac sizes/initializers (Closed)

Created:
6 years, 7 months ago by raymes
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update perf expectations for linux/mac sizes/initializers There was a small regression in http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64929 in the range r270006-r270012 which seems to be normal growth. This updates expectations as per http://www.chromium.org/developers/tree-sheriffs/perf-sheriffs?pli=1#TOC-Updating-Performance-Expectations This is a followup to http://src.chromium.org/viewvc/chrome?revision=270015&view=revision which fixed linux-64 BUG=none TBR=bokan@chromium.org,qyearsley@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf_expectations/perf_expectations.json View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
raymes
Committed patchset #1 manually as r270042 (presubmit successful).
6 years, 7 months ago (2014-05-13 07:16:14 UTC) #1
Ryan Sleevi
Note: This was an addition of a static initializer, which is not normal growth, and ...
6 years, 7 months ago (2014-05-13 07:19:07 UTC) #2
raymes
Ah! Sorry I didn't realise. Thought it was innocuous. I will investigate tomorrow. I included ...
6 years, 7 months ago (2014-05-13 07:57:35 UTC) #3
Ryan Sleevi
6 years, 7 months ago (2014-05-13 08:06:49 UTC) #4
Message was sent while issue was closed.
On 2014/05/13 07:57:35, raymes wrote:
> Ah! Sorry I didn't realise. Thought it was innocuous. I will investigate
> tomorrow. I included the cl range there. Hopefully it is easy to track down.
> On May 13, 2014 5:19 PM, <mailto:rsleevi@chromium.org> wrote:
> 
> > Note: This was an addition of a static initializer, which is not normal
> > growth,
> > and indicative of a suspicious anti-pattern.
> >
> > https://codereview.chromium.org/282803002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

It's http://crrev.com/270007

Source: Diff
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64929/steps/...
with the previous build (
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64928/steps/...
). See the cast_auth_util_nss.cc additions.

Powered by Google App Engine
This is Rietveld 408576698