Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: components/navigation_metrics/navigation_metrics_unittest.cc

Issue 2827983003: Add Incognito Navigation histograms (Closed)
Patch Set: Add negative test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/navigation_metrics/navigation_metrics_unittest.cc
diff --git a/components/navigation_metrics/navigation_metrics_unittest.cc b/components/navigation_metrics/navigation_metrics_unittest.cc
index d1c110759f0167f9125b58bcba4a41024dd32055..0ff3b1803fa21a5271be918e2a35a12004bb7542 100644
--- a/components/navigation_metrics/navigation_metrics_unittest.cc
+++ b/components/navigation_metrics/navigation_metrics_unittest.cc
@@ -13,6 +13,9 @@ const char* const kTestUrl = "http://www.example.com";
const char* const kMainFrameScheme = "Navigation.MainFrameScheme";
const char* const kMainFrameSchemeDifferentPage =
"Navigation.MainFrameSchemeDifferentPage";
+const char* const kMainFrameSchemeOTR = "Navigation.MainFrameSchemeOTR";
+const char* const kMainFrameSchemeDifferentPageOTR =
+ "Navigation.MainFrameSchemeDifferentPageOTR";
} // namespace
@@ -27,6 +30,8 @@ TEST(NavigationMetrics, MainFrameSchemeDifferentDocument) {
test.ExpectUniqueSample(kMainFrameScheme, 1 /* http */, 1);
test.ExpectTotalCount(kMainFrameSchemeDifferentPage, 1);
test.ExpectUniqueSample(kMainFrameSchemeDifferentPage, 1 /* http */, 1);
+ test.ExpectTotalCount(kMainFrameSchemeOTR, 0);
+ test.ExpectTotalCount(kMainFrameSchemeDifferentPageOTR, 0);
}
TEST(NavigationMetrics, MainFrameSchemeSameDocument) {
@@ -37,6 +42,36 @@ TEST(NavigationMetrics, MainFrameSchemeSameDocument) {
test.ExpectTotalCount(kMainFrameScheme, 1);
test.ExpectUniqueSample(kMainFrameScheme, 1 /* http */, 1);
test.ExpectTotalCount(kMainFrameSchemeDifferentPage, 0);
+ test.ExpectTotalCount(kMainFrameSchemeOTR, 0);
+ test.ExpectTotalCount(kMainFrameSchemeDifferentPageOTR, 0);
+}
+
+TEST(NavigationMetrics, MainFrameSchemeDifferentDocumentOTR) {
+ base::HistogramTester test;
+
+ RecordMainFrameNavigation(GURL(kTestUrl), false, true);
+
+ test.ExpectTotalCount(kMainFrameScheme, 1);
+ test.ExpectUniqueSample(kMainFrameScheme, 1 /* http */, 1);
+ test.ExpectTotalCount(kMainFrameSchemeDifferentPage, 1);
+ test.ExpectUniqueSample(kMainFrameSchemeDifferentPage, 1 /* http */, 1);
+ test.ExpectTotalCount(kMainFrameSchemeOTR, 1);
+ test.ExpectUniqueSample(kMainFrameSchemeOTR, 1 /* http */, 1);
+ test.ExpectTotalCount(kMainFrameSchemeDifferentPageOTR, 1);
+ test.ExpectUniqueSample(kMainFrameSchemeDifferentPageOTR, 1 /* http */, 1);
+}
+
+TEST(NavigationMetrics, MainFrameSchemeSameDocumentOTR) {
+ base::HistogramTester test;
+
+ RecordMainFrameNavigation(GURL(kTestUrl), true, true);
+
+ test.ExpectTotalCount(kMainFrameScheme, 1);
+ test.ExpectUniqueSample(kMainFrameScheme, 1 /* http */, 1);
+ test.ExpectTotalCount(kMainFrameSchemeDifferentPage, 0);
+ test.ExpectTotalCount(kMainFrameSchemeOTR, 1);
+ test.ExpectUniqueSample(kMainFrameSchemeOTR, 1 /* http */, 1);
+ test.ExpectTotalCount(kMainFrameSchemeDifferentPageOTR, 0);
}
} // namespace navigation_metrics

Powered by Google App Engine
This is Rietveld 408576698