Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2827873002: Move runtime functions to the more logical runtime_entry.cc. (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move runtime functions to the more logical runtime_entry.cc. Make --trace-runtime-calls respect the isolate filter. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8b96a31c7f13bbc6f33815b0d0b91f60863a0380

Patch Set 1 #

Patch Set 2 : sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2331 lines, -2373 lines) Patch
M runtime/lib/double.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/code_descriptors.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
D runtime/vm/code_generator.h View 1 chunk +0 lines, -28 lines 0 comments Download
D runtime/vm/code_generator.cc View 1 chunk +0 lines, -2301 lines 0 comments Download
M runtime/vm/code_generator_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/code_patcher_arm64_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_arm_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_ia32_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_mips_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_x64_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/deopt_instructions.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate_reload.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate_reload.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/native_entry.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/runtime_entry.h View 3 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/runtime_entry.cc View 2 chunks +2289 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_dbc.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/weak_code.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rmacnak
(Mostly I didn't like seeing code_generator.cc in the binary size tool for the AOT runtime.)
3 years, 8 months ago (2017-04-19 00:02:20 UTC) #2
Cutch
Rubber Stamp LGTM
3 years, 8 months ago (2017-04-19 14:22:30 UTC) #3
rmacnak
Committed patchset #2 (id:20001) manually as 8b96a31c7f13bbc6f33815b0d0b91f60863a0380 (presubmit successful).
3 years, 8 months ago (2017-04-19 17:22:11 UTC) #5
regis
On 2017/04/19 17:22:11, rmacnak wrote: > Committed patchset #2 (id:20001) manually as > 8b96a31c7f13bbc6f33815b0d0b91f60863a0380 (presubmit ...
3 years, 8 months ago (2017-04-19 19:55:39 UTC) #6
rmacnak
On 2017/04/19 19:55:39, regis wrote: > On 2017/04/19 17:22:11, rmacnak wrote: > > Committed patchset ...
3 years, 8 months ago (2017-04-19 20:25:49 UTC) #7
regis
3 years, 8 months ago (2017-04-19 20:38:09 UTC) #8
Message was sent while issue was closed.
On 2017/04/19 20:25:49, rmacnak wrote:
> On 2017/04/19 19:55:39, regis wrote:
> > On 2017/04/19 17:22:11, rmacnak wrote:
> > > Committed patchset #2 (id:20001) manually as
> > > 8b96a31c7f13bbc6f33815b0d0b91f60863a0380 (presubmit successful).
> > 
> > How about code_generator_test.cc?
> 
> Those tests are related to code generation and not specific to runtime calls.

Maybe we could move them to another *_test.cc file, such as compiler_test.cc and
remove code_generator_test.cc. But not important.
Thanks for removing code_generator.cc.

Powered by Google App Engine
This is Rietveld 408576698