Issue 2827863003: Revert "New Lint quick-fix: prefer_collection_literals (#29378)"

Issue 2827863003: Revert "New Lint quick-fix: prefer_collection_literals (#29378)" (Closed)

Created:
3 years, 8 months ago by erikcorry

Modified:
3 years, 8 months ago

Reviewers:
casanueva, karlklose, floitsch

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "New Lint quick-fix: prefer_collection_literals (#29378)" This reverts commit 6a56c86c8181f4d9115a76b6fde81da44413d07f. This a gardener revert to fix buildbot redness. R=karlklose@google.com, loitsch@google.com TBR=casanueva@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/23c0caf4dc90b1f1ce1934c069e6e1aaf8146929

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -135 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/fix.dart	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	3 chunks	+3 lines, -25 lines	0 comments	Download
M	pkg/analysis_server/test/mock_sdk.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/correction/fix_test.dart	View	1 chunk	+0 lines, -104 lines	0 comments	Download

Messages

Total messages: 8 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

erikcorry

Sample failure: python tools/test.py -mrelease --checked -t60 --use-sdk pkg/analysis_server/test/services/correction/fix_test 00:17 +262 -1: LintFixTest | test_replaceWithLiteral_linkedHashMap_withCommentsInGeneric ...

3 years, 8 months ago (2017-04-19 10:32:40 UTC) #2

Sample failure:

python tools/test.py -mrelease --checked -t60 --use-sdk
pkg/analysis_server/test/services/correction/fix_test

00:17 +262 -1: LintFixTest |
test_replaceWithLiteral_linkedHashMap_withCommentsInGeneric

  type 'UndefinedTypeImpl' is not a subtype of type 'InterfaceType' of 'type'
where
    UndefinedTypeImpl is from package:analyzer/src/dart/element/type.dart
    InterfaceType is from package:analyzer/dart/element/type.dart
  
  package:analysis_server/src/services/correction/fix_internal.dart 1908:49 
FixProcessor._addFix_replaceWithLiteral
  package:analysis_server/src/services/correction/fix_internal.dart 388:9   
FixProcessor.compute
  package:analysis_server/src/services/correction/fix_internal.dart 81:41   
DefaultFixContributor.internalComputeFixes
  package:analysis_server/plugin/edit/fix/fix_dart.dart 79:12               
DartFixContributor.computeFixes
  pkg/analysis_server/test/services/correction/fix_test.dart 182:26         
BaseFixProcessorTest._computeFixes
  pkg/analysis_server/test/services/correction/fix_test.dart 140:29         
BaseFixProcessorTest._assertHasFix
  pkg/analysis_server/test/services/correction/fix_test.dart 5700:17        
LintFixTest.applyFix
  pkg/analysis_server/test/services/correction/fix_test.dart 5967:11        
LintFixTest.test_replaceWithLiteral_linkedHashMap_withCommentsInGeneric
  dart:mirrors                                                              
_LocalInstanceMirror.invoke
  package:test_reflective_loader/test_reflective_loader.dart 239:35         
_runTest.<fn>
  ===== asynchronous gap ===========================
  dart:async                                                                
_Completer.completeError
  package:analysis_server/src/services/correction/fix_internal.dart 396:3   
FixProcessor.compute
  ===== asynchronous gap ===========================
  dart:async                                                                
Future.Future.microtask
  package:analysis_server/src/services/correction/fix_internal.dart 152:37  
FixProcessor.compute
  package:analysis_server/src/services/correction/fix_internal.dart 81:41   
DefaultFixContributor.internalComputeFixes
  ===== asynchronous gap ===========================
  dart:async                                                                
Future.Future.microtask
  package:analysis_server/src/services/correction/fix_internal.dart 78:72   
DefaultFixContributor.internalComputeFixes
  package:analysis_server/plugin/edit/fix/fix_dart.dart 79:12               
DartFixContributor.computeFixes
  ===== asynchronous gap ===========================
  dart:async                                                                
Future.Future.microtask
  package:analysis_server/plugin/edit/fix/fix_dart.dart 59:60               
DartFixContributor.computeFixes
  pkg/analysis_server/test/services/correction/fix_test.dart 182:26         
BaseFixProcessorTest._computeFixes
  ===== asynchronous gap ===========================
  dart:async                                                                
Future.Future.microtask
  pkg/analysis_server/test/services/correction/fix_test.dart 169:62         
BaseFixProcessorTest._computeFixes
  pkg/analysis_server/test/services/correction/fix_test.dart 140:29         
BaseFixProcessorTest._assertHasFix
  ===== asynchronous gap ===========================
  dart:async                                                                
Future.Future.microtask
  pkg/analysis_server/test/services/correction/fix_test.dart 139:70         
BaseFixProcessorTest._assertHasFix
  pkg/analysis_server/test/services/correction/fix_test.dart 5700:17        
LintFixTest.applyFix
  ===== asynchronous gap ===========================
  dart:async                                                                
Future.Future.microtask
  pkg/analysis_server/test/services/correction/fix_test.dart 5699:39        
LintFixTest.applyFix
  pkg/analysis_server/test/services/correction/fix_test.dart 5967:11        
LintFixTest.test_replaceWithLiteral_linkedHashMap_withCommentsInGeneric
  ===== asynchronous gap ===========================
  dart:async                                                                
_asyncThenWrapperHelper
  pkg/analysis_server/test/services/correction/fix_test.dart 5961:71        
LintFixTest.test_replaceWithLiteral_linkedHashMap_withCommentsInGeneric
  dart:mirrors                                                              
_LocalInstanceMirror.invoke
  package:test_reflective_loader/test_reflective_loader.dart 239:35         
_runTest.<fn>
  ===== asynchronous gap ===========================
  dart:async                                                                
_Future.then
  package:test_reflective_loader/test_reflective_loader.dart 239:8          
_runTest
  package:test_reflective_loader/test_reflective_loader.dart 126:18         
defineReflectiveTests.<fn>.<fn>

erikcorry

3 years, 8 months ago (2017-04-19 10:49:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
23c0caf4dc90b1f1ce1934c069e6e1aaf8146929 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages