Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 282783004: Reland of "v8::TryCatch now works correctly with ASAN's UseAfterReturn mode enabled." (Closed)

Created:
6 years, 7 months ago by Igor Sheludko
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Reland "v8::TryCatch now works correctly with ASAN's UseAfterReturn mode enabled." BUG=chromium:369962 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21382

Patch Set 1 : Pervious attempt #

Patch Set 2 : Remake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -64 lines) Patch
M include/v8.h View 1 2 chunks +18 lines, -1 line 0 comments Download
M src/api.cc View 1 4 chunks +20 lines, -1 line 0 comments Download
M src/arm/simulator-arm.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M src/base/macros.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/ia32/simulator-ia32.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/isolate.h View 1 4 chunks +9 lines, -6 lines 0 comments Download
M src/isolate.cc View 1 4 chunks +6 lines, -20 lines 0 comments Download
M src/mips/simulator-mips.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M src/x64/simulator-x64.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/zone.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 7 months ago (2014-05-20 07:54:14 UTC) #1
Jakob Kummerow
lgtm
6 years, 7 months ago (2014-05-20 09:48:35 UTC) #2
Igor Sheludko
6 years, 7 months ago (2014-05-20 10:14:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21382 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698