Get Proguard flags from GMS clients (upstream part)

build/android/play_services/preprocess.py

 #!/usr/bin/env python
 #
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 '''Prepares the Google Play services split client libraries before usage by
 Chrome's build system.
 
 We need to preprocess Google Play services before using it in Chrome builds
@@ skipping 42 matching lines @@
                              '--repository',
                              help=('the Google Play services repository '
                                    'location'),
                              required=True,
                              metavar='FILE')
   required_args.add_argument('-o',
                              '--out-dir',
                              help='the output directory',
                              required=True,
                              metavar='FILE')
+  required_args.add_argument('-g',
+                             '--gni-out-file',
+                             help='the GN output file',
+                             required=True,
+                             metavar='FILE')
   required_args.add_argument('-c',
                              '--config-file',
                              help='the config file path',
                              required=True,
                              metavar='FILE')
   parser.add_argument('--config-help',
                       action='custom_help',
                       custom_help_text=utils.ConfigParser.__doc__,
                       help='show the configuration file format help')
 
   args = parser.parse_args()
 
   return ProcessGooglePlayServices(args.repository,
                                    args.out_dir,
+                                   args.gni_out_file,
                                    args.config_file)
 
 
-def ProcessGooglePlayServices(repo, out_dir, config_path):
+def ProcessGooglePlayServices(repo, out_dir, gni_out_file, config_path):
   config = utils.ConfigParser(config_path)
 
   tmp_root = tempfile.mkdtemp()
   try:
     tmp_paths = _SetupTempDir(tmp_root)
     _ImportFromExtractedRepo(config, tmp_paths, repo)
     _ProcessResources(config, tmp_paths, repo)
     _CopyToOutput(tmp_paths, out_dir)
+    _EnumerateProguardFiles(gni_out_file, out_dir)
     _UpdateVersionInConfig(config, tmp_paths)
   finally:
     shutil.rmtree(tmp_root)
 
   return 0
 
 
 def _SetupTempDir(tmp_root):
   tmp_paths = {
       'root': tmp_root,
@@ skipping 81 matching lines @@
         shutil.copy(os.path.join(repo, whitelisted_file), rebased_res)
       finally:
         _MakeWritable(rebased_res)
 
 
 def _CopyToOutput(tmp_paths, out_dir):
   shutil.rmtree(out_dir, ignore_errors=True)
   shutil.copytree(tmp_paths['imported_clients'], out_dir)
 
 
+# Write a GN file containing a list of each GMS client's proguard file (if any).
+def _EnumerateProguardFiles(gni_path, out_dir):
+  gni_dir = os.path.dirname(gni_path)
+  script_name = os.path.relpath(sys.argv[0], gni_dir)
+
+  gni_text = '# This file generated by ' + script_name + '\n'

[Maria, 2017/04/19 05:40:35]

Copyright should go here I guess.

+  gni_text += 'gms_proguard_configs = [\n'

[jbudorick, 2017/04/18 23:59:12]

Build the (sorted) list of extant proguard files, then just use something like

  gni_text += 'gms_proguard_configs = %s' % pprint.pformat(gms_proguard_configs)

The resulting .gni will need to be formatted, but I'd rather than be the case w/
less to maintain here.

[paulmiller, 2017/04/19 17:30:13]

It looks like pformat emits single quotes. Not sure if GN will accept that.

[jbudorick, 2017/04/19 18:42:26]

Ah, yeah, you're right.

+  for client_dir in os.listdir(out_dir):
+    proguard_path = os.path.join(
+        out_dir, client_dir, 'proguard.txt')
+    if os.path.exists(os.path.dirname(proguard_path)):
+      relative = os.path.relpath(proguard_path, gni_dir)
+      gni_text += '  "' + relative + '",\n'
+  gni_text += ']\n'
+
+  with open(gni_path, 'w') as gni_file:
+    gni_file.write(gni_text)
+
+
 def _UpdateVersionInConfig(config, tmp_paths):
   version_xml_path = os.path.join(tmp_paths['imported_clients'],
                                   config.version_xml_path)
   play_services_full_version = utils.GetVersionNumberFromLibraryResources(
       version_xml_path)
   config.UpdateVersionNumber(play_services_full_version)
 
 
 def _ExtractAll(zip_path, out_path):
   with zipfile.ZipFile(zip_path, 'r') as zip_file:
     zip_file.extractall(out_path)
 
 if __name__ == '__main__':
   sys.exit(main())