Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2827793003: Plumb TypeInferrer through KernelExpression._inferExpression. (Closed)

Created:
3 years, 8 months ago by Paul Berry
Modified:
3 years, 8 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Plumb TypeInferrer through KernelExpression._inferExpression. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/13941eaa0327bbbb29cf6cf6f7be4788edd8456c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 7 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 8 months ago (2017-04-18 22:59:01 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-18 23:12:51 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 13941eaa0327bbbb29cf6cf6f7be4788edd8456c (presubmit successful).
3 years, 8 months ago (2017-04-19 01:40:53 UTC) #5
ahe
3 years, 8 months ago (2017-04-19 04:06:22 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698