Format all files under tools and utils directory.

Format all files under tools and utils directory.

BUG=
R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/119b2d58ced0a102a01228ea6b3eb8189ec333f0

[Jacob, 2017-04-18 20:10:56]

jacobr@google.com changed reviewers:
+ terry@google.com

[Jacob, 2017-04-19 15:01:22]

jacobr@google.com changed reviewers:
+ efortuna@google.com

[terry, 2017-04-20 13:16:37]

lgtm, just minor nits and a dartfmt that I think makes debugging a pain.

Should run dart/tools/dom/script/go.sh to make sure the changes in tools/dom/src
has no affect on the output since these files are embedded in the files
generated int dart/sdk/lib by go.sh - nothing should change.

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/scripts/idlre...
File tools/dom/scripts/idlrenderer.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/scripts/idlre...
tools/dom/scripts/idlrenderer.dart:23: // TODO: revert to  indented(action()) {
Might want this above the line indented(action)?

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/src/Attribute...
File tools/dom/src/AttributeMap.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/src/Attribute...
tools/dom/src/AttributeMap.dart:15: });
Nicer for debugging too.

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/src/_chrome/a...
File tools/dom/src/_chrome/app_runtime.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/src/_chrome/a...
tools/dom/src/_chrome/app_runtime.dart:18: if (entry != null) this.entry =
entry;
This kind of formatting will make it harder to debug and set BP on this.entry =
entry need to always hit the if then step - right?

https://codereview.chromium.org/2827793002/diff/20001/utils/peg/pegparser.dart
File utils/peg/pegparser.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/utils/peg/pegparser.dar...
utils/peg/pegparser.dart:208: y,
Ugh!, not as pretty - but I guess that's life...

https://codereview.chromium.org/2827793002/diff/20001/utils/tests/peg/peg_tes...
File utils/tests/peg/peg_test.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/utils/tests/peg/peg_tes...
utils/tests/peg/peg_test.dart:204: ]);
Ugh!, old not dartfmt was easier to grasp.

[Jacob, 2017-04-20 15:33:14]

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/scripts/idlre...
File tools/dom/scripts/idlrenderer.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/scripts/idlre...
tools/dom/scripts/idlrenderer.dart:23: // TODO: revert to  indented(action()) {
On 2017/04/20 13:16:36, terry wrote:
> Might want this above the line indented(action)?

Done.

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/src/Attribute...
File tools/dom/src/AttributeMap.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/src/Attribute...
tools/dom/src/AttributeMap.dart:15: });
On 2017/04/20 13:16:36, terry wrote:
> Nicer for debugging too.

Acknowledged.

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/src/_chrome/a...
File tools/dom/src/_chrome/app_runtime.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/tools/dom/src/_chrome/a...
tools/dom/src/_chrome/app_runtime.dart:18: if (entry != null) this.entry =
entry;
On 2017/04/20 13:16:36, terry wrote:
> This kind of formatting will make it harder to debug and set BP on this.entry
=
> entry need to always hit the if then step - right?

The style guide says this is the correct way to format single line 
if statements without curly braces.
https://www.dartlang.org/guides/language/effective-dart/style#do-use-curly-br...
Coming from editing blink code I do prefer the blink style as well but I don't
care deeply about it.
Good news is more and more debugging tools allow conditional breakpoints and
breakpoints with column as well as line numbers so setting a breakpoint for
these cases should be ok.

https://codereview.chromium.org/2827793002/diff/20001/utils/peg/pegparser.dart
File utils/peg/pegparser.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/utils/peg/pegparser.dar...
utils/peg/pegparser.dart:208: y,
On 2017/04/20 13:16:36, terry wrote:
> Ugh!, not as pretty - but I guess that's life...

agreed that this is really ugly. Unfortunately I cannot force an alternate
indentation of arguments using the same 
// trick that works for Lists.
Filed a bug on the formatter on this.
https://github.com/dart-lang/dart_style/issues/620

https://codereview.chromium.org/2827793002/diff/20001/utils/tests/peg/peg_tes...
File utils/tests/peg/peg_test.dart (right):

https://codereview.chromium.org/2827793002/diff/20001/utils/tests/peg/peg_tes...
utils/tests/peg/peg_test.dart:204: ]);
On 2017/04/20 13:16:37, terry wrote:
> Ugh!, old not dartfmt was easier to grasp.

I agree this is not ideal. Added // comments to maintain the key property of the
original formatting that each child list was on its own line.

[Jacob, 2017-04-20 16:08:36]

Description was changed from

==========
Format all files under tools and utils directory.

BUG=
==========

to

==========
Format all files under tools and utils directory.

BUG=
R=terry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/119b2d58ced0a102a01228ea6b3eb8189ec333f0
==========

[Jacob, 2017-04-20 16:08:38]

Committed patchset #4 (id:60001) manually as
119b2d58ced0a102a01228ea6b3eb8189ec333f0 (presubmit successful).