Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Unified Diff: gpu/command_buffer/service/texture_manager.h

Issue 2827573007: Reset TexImage2D base level to workaround Intel mac driver bug (Closed)
Patch Set: Add gpu unittests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/texture_manager.h
diff --git a/gpu/command_buffer/service/texture_manager.h b/gpu/command_buffer/service/texture_manager.h
index 02c5c1119c781cf6a62d236fcfe521d00ac3ceef..73be925b3229e411743ccd047e50365b0e1f9823 100644
--- a/gpu/command_buffer/service/texture_manager.h
+++ b/gpu/command_buffer/service/texture_manager.h
@@ -697,7 +697,7 @@ class GPU_EXPORT TextureRef : public base::RefCounted<TextureRef> {
// Holds data that is per gles2_cmd_decoder, but is related to to the
// TextureManager.
-struct DecoderTextureState {
+struct GPU_EXPORT DecoderTextureState {
// total_texture_upload_time automatically initialized to 0 in default
// constructor.
explicit DecoderTextureState(const GpuDriverBugWorkarounds& workarounds);
@@ -1129,6 +1129,13 @@ class GPU_EXPORT TextureManager : public base::trace_event::MemoryDumpProvider {
texture_ref, function_name, args);
}
+ void DoTexImage(DecoderTextureState* texture_state,
+ ContextState* state,
+ DecoderFramebufferState* framebuffer_state,
+ const char* function_name,
+ TextureRef* texture_ref,
+ const DoTexImageArguments& args);
+
yizhou.jiang 2017/06/09 07:58:16 I move DoTexImage to public in order to test it in
private:
friend class Texture;
friend class TextureRef;
@@ -1138,14 +1145,6 @@ class GPU_EXPORT TextureManager : public base::trace_event::MemoryDumpProvider {
GLenum target,
GLuint* black_texture);
- void DoTexImage(
- DecoderTextureState* texture_state,
- ContextState* state,
- DecoderFramebufferState* framebuffer_state,
- const char* function_name,
- TextureRef* texture_ref,
- const DoTexImageArguments& args);
-
// Reserve memory for the texture and set its attributes so it can be filled
// with TexSubImage. The image contents are undefined after this function,
// so make sure it's subsequently filled in its entirety.

Powered by Google App Engine
This is Rietveld 408576698